镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Add async execution RFC - #4556

Open
TrueDoctor wants to merge 2 commits into
masterfrom
async-execution-rfc
Open

TrueDoctor wants to merge 2 commits into
masterfrom
async-execution-rfc

Conversation

@TrueDoctor

Copy link
Copy Markdown
Member

No description provided.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Confidence score: 3/5

  • In node-graph/rfcs/async-execution-model.md, changing url without changing the context can reuse the previous response instead of starting a request for the new URL. Include evaluated input identity in the slot key.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="node-graph/rfcs/async-execution-model.md">

<violation number="1" location="node-graph/rfcs/async-execution-model.md:71">
P1: The slot key omits evaluated inputs, so changing `url` while the context stays the same reuses the previous response instead of spawning a request for the new URL. Include input identity in the key alongside the retained context, or invalidate the slot when inputs change.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

}
```

The generated struct holds a slot map keyed by the context hash. On eval: a completed slot returns `Final`; an in-flight slot returns `Partial(placeholder)`; no slot means insert a marker, spawn, and return the placeholder. The graph never suspends, so every evaluation runs to completion and produces a frame. Async bodies cannot touch the context because the future has to be `'static`. The generated code checks the input statuses before spawning, so no request goes out based on provisional data.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: The slot key omits evaluated inputs, so changing url while the context stays the same reuses the previous response instead of spawning a request for the new URL. Include input identity in the key alongside the retained context, or invalidate the slot when inputs change.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At node-graph/rfcs/async-execution-model.md, line 71:

<comment>The slot key omits evaluated inputs, so changing `url` while the context stays the same reuses the previous response instead of spawning a request for the new URL. Include input identity in the key alongside the retained context, or invalidate the slot when inputs change.</comment>

<file context>
@@ -0,0 +1,175 @@
+}
+```
+
+The generated struct holds a slot map keyed by the context hash. On eval: a completed slot returns `Final`; an in-flight slot returns `Partial(placeholder)`; no slot means insert a marker, spawn, and return the placeholder. The graph never suspends, so every evaluation runs to completion and produces a frame. Async bodies cannot touch the context because the future has to be `'static`. The generated code checks the input statuses before spawning, so no request goes out based on provisional data.
+
+## Invalidation by generation
</file context>

This branch was successfully deployed

1 active deployment
graphite-dev (Preview) — 1d6f19e6 Deployed Sep 20, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant