Repository navigation
Add async execution RFC - #4556
Open
TrueDoctor wants to merge 2 commits into
Open
TrueDoctor wants to merge 2 commits into
TrueDoctor wants to merge 2 commits into
Conversation
TrueDoctor
marked this pull request as ready for review
October 4, 2026 04:25
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 3/5
- In
node-graph/rfcs/async-execution-model.md, changingurlwithout changing the context can reuse the previous response instead of starting a request for the new URL. Include evaluated input identity in the slot key.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="node-graph/rfcs/async-execution-model.md">
<violation number="1" location="node-graph/rfcs/async-execution-model.md:71">
P1: The slot key omits evaluated inputs, so changing `url` while the context stays the same reuses the previous response instead of spawning a request for the new URL. Include input identity in the key alongside the retained context, or invalidate the slot when inputs change.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| } | ||
| ``` | ||
|
|
||
| The generated struct holds a slot map keyed by the context hash. On eval: a completed slot returns `Final`; an in-flight slot returns `Partial(placeholder)`; no slot means insert a marker, spawn, and return the placeholder. The graph never suspends, so every evaluation runs to completion and produces a frame. Async bodies cannot touch the context because the future has to be `'static`. The generated code checks the input statuses before spawning, so no request goes out based on provisional data. |
Contributor
There was a problem hiding this comment.
P1: The slot key omits evaluated inputs, so changing url while the context stays the same reuses the previous response instead of spawning a request for the new URL. Include input identity in the key alongside the retained context, or invalidate the slot when inputs change.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At node-graph/rfcs/async-execution-model.md, line 71:
<comment>The slot key omits evaluated inputs, so changing `url` while the context stays the same reuses the previous response instead of spawning a request for the new URL. Include input identity in the key alongside the retained context, or invalidate the slot when inputs change.</comment>
<file context>
@@ -0,0 +1,175 @@
+}
+```
+
+The generated struct holds a slot map keyed by the context hash. On eval: a completed slot returns `Final`; an in-flight slot returns `Partial(placeholder)`; no slot means insert a marker, spawn, and return the placeholder. The graph never suspends, so every evaluation runs to completion and produces a frame. Async bodies cannot touch the context because the future has to be `'static`. The generated code checks the input statuses before spawning, so no request goes out based on provisional data.
+
+## Invalidation by generation
</file context>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.