[sdodsley]

SUMMARY

Fixes the defects found by running a hardware QA suite over every module of the collection against a FlashArray//X50R2 and a FlashArray//C60R3 (Purity//FA 6.10.6, REST 2.54, py-pure-client 1.94.1). The suite runs each module twice per mutation (the repeat must be a no-op), reads the result back through purefa_info, and leaves the arrays as it found them.

Highlights, all reproduced on hardware before the fix:

• purefa_info: gather_subset: all crashed in the host-group performance dict and dropped the default section; performance attributes are now read defensively and keyed correctly; adds default.banner, config.alert_watchers, directory exports, every SAML IdP, management-access policy rules and extra password/SMB policy fields.
• purefa_hardware sent an empty PATCH body (Hardware instead of HardwarePatch).
• purefa_dns refused to update the management configuration, crashed when adding a source and could delete the management DNS on state: absent of an unknown name.
• purefa_pgsched sent snap_at/replicate_at in seconds instead of milliseconds (1000x off) and the array needs enabled alongside them.
• purefa_pod: quota clear crashed, default_protection_pg: [] never cleared, absent on a destroyed pod raised; purefa_default_protection pod scope sent an invalid body.
• Rename repeats in purefa_volume, purefa_hg, purefa_vg, purefa_realm, purefa_tgroup, purefa_endpoint, purefa_policy_management_access failed or re-created the old object.
• purefa_snap repeat create failed "Name already in use"; purefa_pg member removal and target handling; purefa_dirsnap keep_for; purefa_policy first NFS rule, in-place rule modification, autodir rename, anonuid/anongid version checks.
• purefa_connect matched the fleet-management connection sharing the peer's address and would have patched it; purefa_fleet member removal TypeError.
• purefa_user / purefa_token API token handling; purefa_network_access_policy rule lookups; purefa_admin lockout clear and SSO disable; purefa_smtp clearing; purefa_ntp inverted context check; purefa_phonehome, purefa_maintenance, purefa_snmp_agent, purefa_snmp idempotency; read-only state: test operations report changed=False and tolerate sparse results.

Verification: full suite against this branch on 2026-10-20 (see the QA report for the final numbers). The remaining skips are environment gaps (no fleet-free array, AD, KMIP, SAML IdP, offload target, NFS client).

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

purefa_info, purefa_hardware, purefa_dns, purefa_network, purefa_network_access_policy, purefa_policy_management_access, purefa_admin, purefa_timeout, purefa_logging, purefa_ra, purefa_snmp, purefa_snmp_agent, purefa_alert, purefa_syslog, purefa_ntp, purefa_kmip, purefa_saml, purefa_cbsexpand, purefa_phonehome, purefa_maintenance, purefa_messages, purefa_audits, purefa_sessions, purefa_smtp, purefa_syslog_settings, purefa_eradication, purefa_volume, purefa_snap, purefa_hg, purefa_vg, purefa_pg, purefa_pgsched, purefa_pgsnap, purefa_host, purefa_endpoint, purefa_volume_tags, purefa_pod, purefa_default_protection, purefa_realm, purefa_tgroup, purefa_fs, purefa_dirsnap, purefa_policy, purefa_user, purefa_token, purefa_connect, purefa_fleet, purefa_ad, purefa_offload, purefa_vnc, purefa_inventory, purefa_certs, purefa_ds, purefa_dsrole

ADDITIONAL INFORMATION

Behaviour changes worth noting for reviewers: purefa_hardware.enabled is now required; purefa_pg.enabled, purefa_pgsched.enabled, purefa_vg.priority_*, purefa_eradication delays and purefa_policy_management_access enabled/aggregation_strategy lost their implicit defaults and are only applied when supplied (creation keeps the old effective defaults); purefa_snap gains with_default_protection; purefa_info.config.saml2sso is now keyed by IdP name; purefa_certs generate: true always regenerates (documented); a community-only change to an SNMP v2c manager and a passphrase-only change to the SNMP agent are no longer applied because the array masks those values (documented).

Unit tests: 2883 passing. ansible-test sanity (validate-modules, pep8, pylint, yamllint, compile, import) clean.

🤖 Generated with Claude Code