镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Fix economy usernames being unsanitized in some places - #4484

Merged
mdcfe merged 13 commits into
2.xfrom
debug/towny-usermap-logging
Aug 28, 2021
Merged

mdcfe merged 13 commits into
2.xfrom
debug/towny-usermap-logging

Conversation

@JRoy

@JRoy JRoy commented Aug 26, 2021 •

Copy link
Copy Markdown
Member

Pretty sure this caused the last of our economy woes.

PEOPLE WHO GET THOSE "FOUND NEW UUID BUT NOT REPLACING ERRORS" NEED TO DELETE THE FILE IN USERDATA ASSOCIATED WITH THE FIRST UUID IN THAT MESSAGE. THOSE WERE GENERATED NPC ACCOUNTS FROM THE LEGACY SYSTEM AND GET LOADED INTO THE USERMAP WHEN WE DO getUniqueUsers IF THEY HAVE ONLY npc:true AND money: 0 AND A last-account-name YOU CAN SAFELY DELETE THEM WHEN THE SERVER STOPS AND THE WARNING WILL GO AWAY.

ignore that ^ lol because #4490 is a thing

also adds some more logging for debug mode

@JRoy JRoy added type: bugfix PRs that fix bugs in EssentialsX. module: main Issues or PRs for the main Essentials module labels Aug 26, 2021
@JRoy JRoy added this to the 2.19.0 milestone Aug 26, 2021
mdcfe
mdcfe previously requested changes Aug 26, 2021
Comment thread Essentials/src/main/java/com/earth2me/essentials/UserMap.java Outdated
Comment thread Essentials/src/main/java/com/earth2me/essentials/UserMap.java Outdated
@JRoy
JRoy requested a review from mdcfe August 26, 2021 20:20
@mdcfe
mdcfe enabled auto-merge (squash) August 28, 2021 16:32
@mdcfe
mdcfe merged commit 4bee159 into 2.x Aug 28, 2021
@JRoy
JRoy deleted the debug/towny-usermap-logging branch August 31, 2021 20:34
ressidell pushed a commit to ressidell/Essentials that referenced this pull request Apr 27, 2025
)

Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com>

This PR fixes various issues with NPC accounts:
- Fixes some NPC account names not being sanitised
- Fixes wrong keys being used when manually generating a NPC account file
- Adds some debug logging to `UserMap` name lookups
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
)

Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com>

This PR fixes various issues with NPC accounts:
- Fixes some NPC account names not being sanitised
- Fixes wrong keys being used when manually generating a NPC account file
- Adds some debug logging to `UserMap` name lookups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: main Issues or PRs for the main Essentials module type: bugfix PRs that fix bugs in EssentialsX.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants