镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Allow disabling MOTD task and cancel on player logout - #4411

Merged
mdcfe merged 6 commits into
EssentialsX:2.xfrom
JRoy:fix/delay-motd-offline
Aug 9, 2021
Merged

mdcfe merged 6 commits into
EssentialsX:2.xfrom
JRoy:fix/delay-motd-offline

Conversation

@JRoy

@JRoy JRoy commented Jul 30, 2021 •

Copy link
Copy Markdown
Member

This PR allows setting delay-motd to a negative value in config.yml to disable the MOTD join task without disabling /motd, and fixes an issue where delayed MOTD tasks would run even after a player logged out (in case someone previously set an insanely high MOTD delay to "disable" the MOTD on join).

Fixes #4408.

@JRoy JRoy added the type: bugfix PRs that fix bugs in EssentialsX. label Jul 30, 2021
@JRoy JRoy added this to the 2.19.0 milestone Jul 30, 2021
@triagonal triagonal added the module: main Issues or PRs for the main Essentials module label Jul 31, 2021
@mdcfe mdcfe changed the title Fix delayed MOTD task running when players go offline Allow disabling MOTD task and cancel on player logout Aug 9, 2021
@mdcfe
mdcfe merged commit 14fbfe3 into EssentialsX:2.x Aug 9, 2021
@mdcfe
mdcfe deleted the fix/delay-motd-offline branch August 9, 2021 19:22
ressidell pushed a commit to ressidell/Essentials that referenced this pull request Apr 27, 2025
This PR allows setting `delay-motd` to a negative value in `config.yml` to disable the MOTD join task without disabling `/motd`, and fixes an issue where delayed MOTD tasks would run even after a player logged out (in case someone previously set an insanely high MOTD delay to "disable" the MOTD on join).

Fixes EssentialsX#4408.
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
This PR allows setting `delay-motd` to a negative value in `config.yml` to disable the MOTD join task without disabling `/motd`, and fixes an issue where delayed MOTD tasks would run even after a player logged out (in case someone previously set an insanely high MOTD delay to "disable" the MOTD on join).

Fixes EssentialsX#4408.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: main Issues or PRs for the main Essentials module type: bugfix PRs that fix bugs in EssentialsX.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in console with insane amount of delay on MOTD.

3 participants