Repository navigation
Lazy load locations in Configurate - #4203
Merged
Merged
Conversation
zml2008
previously approved these changes
Jun 7, 2021
zml2008
left a comment
Contributor
There was a problem hiding this comment.
i'd call it LazyLocation but seems fine :)
JRoy
force-pushed
the
fix/configurate-worlds
branch
from
June 7, 2021 18:13
95bbc24 to
15b5a2c
Compare
mdcfe
approved these changes
Jun 7, 2021
ressidell
pushed a commit
to ressidell/Essentials
that referenced
this pull request
Apr 27, 2025
rewsdjad1
pushed a commit
to rewsdjad1/EssentialsXPlus
that referenced
this pull request
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still waiting for confirmation that this fixes the problem but pretty sure this does. Before Configurate, we lazy loaded locations in and I forgot that wasn't happening in object mapped classes so here we are. 90% of the time it took to fix this was from reworking how tests create servers because by the end of the test lifecycle there are about 10 different instances of FakeServer and about 4 different FakeWorlds and that's so braindead