Repository navigation
Fix vault provider account creation - #4147
Merged
Merged
Conversation
This check swallowed any warnings spit out by UserMap#trackUUID causing problems for plugins which didn't check the success of this method and thus leading to possible stack overflow exceptions or other unexpected behavior
…Account Complete oversight as I was under the impression tracking the UUID would create the files for us. We do moderate amounts of trolling.
JRoy
enabled auto-merge (squash)
May 13, 2021 00:34
pop4959
reviewed
May 13, 2021
pop4959
approved these changes
May 13, 2021
ressidell
pushed a commit
to ressidell/Essentials
that referenced
this pull request
Apr 27, 2025
Removed an extraneous name->uuid check This check swallowed any warnings spit out by UserMap#trackUUID causing problems for plugins which didn't check the success of this method and thus leading to possible stack overflow exceptions or other unexpected behavior Actually save accounts created with VaultEconomyProvider#createPlayerAccount Complete oversight as I was under the impression tracking the UUID would create the files for us.
rewsdjad1
pushed a commit
to rewsdjad1/EssentialsXPlus
that referenced
this pull request
Aug 13, 2026
Removed an extraneous name->uuid check This check swallowed any warnings spit out by UserMap#trackUUID causing problems for plugins which didn't check the success of this method and thus leading to possible stack overflow exceptions or other unexpected behavior Actually save accounts created with VaultEconomyProvider#createPlayerAccount Complete oversight as I was under the impression tracking the UUID would create the files for us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vault sux, read commit descriptions