镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Fix various trade sign issues - #4056

Merged
JRoy merged 6 commits into
EssentialsX:2.xfrom
JRoy:trade-signs-are-my-passion
Apr 14, 2021
Merged

JRoy merged 6 commits into
EssentialsX:2.xfrom
JRoy:trade-signs-are-my-passion

Conversation

@JRoy

@JRoy JRoy commented Mar 13, 2021 •

Copy link
Copy Markdown
Member

Fixes #3384

  • Line text length is now checked before each Sign#setLine check

Fixes #4014

  • The total amount of an itemstack inside a given players inventory is now used rather than just the amount of the held itemstack. Fixes restocking trades over the max stack size.

@JRoy JRoy added the type: bugfix PRs that fix bugs in EssentialsX. label Mar 13, 2021
@JRoy JRoy added this to the 2.19.0 milestone Mar 13, 2021
@JRoy
JRoy requested a review from mdcfe March 29, 2021 18:04
@JRoy JRoy changed the title Fix various issues with trade sign line lengths Fix various trade sign issues Apr 14, 2021
@JRoy
JRoy merged commit 5171215 into EssentialsX:2.x Apr 14, 2021
@JRoy
JRoy deleted the trade-signs-are-my-passion branch April 14, 2021 16:24
ressidell pushed a commit to ressidell/Essentials that referenced this pull request Apr 27, 2025
Fixes various bugs with line length validation and fixes issues with overfilled stacks.
rewsdjad1 pushed a commit to rewsdjad1/EssentialsXPlus that referenced this pull request Aug 13, 2026
Fixes various bugs with line length validation and fixes issues with overfilled stacks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bugfix PRs that fix bugs in EssentialsX.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to restock trade signs if you're trying to sell more than 64 Trade Signs: Duplication Glitch

2 participants