Repository navigation
Fix warp messages sending incorrectly with teleport delays - #3696
Merged
Merged
Conversation
JRoy
approved these changes
Oct 3, 2020
JRoy
left a comment
Member
There was a problem hiding this comment.
I wonder who caused this regression 😳
Member
|
This may possibly fix #3554 |
ressidell
pushed a commit
to ressidell/Essentials
that referenced
this pull request
Apr 27, 2025
…sX#3696) Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
rewsdjad1
pushed a commit
to rewsdjad1/EssentialsXPlus
that referenced
this pull request
Aug 13, 2026
…sX#3696) Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1044
This PR sends the warp message only when the future for the teleport completes successfully (does not fail anything such as a cooldown, which then prints a separate message).