Repository navigation
Rework Currency Symbol Parsing - #3628
Merged
Merged
Conversation
Kits should be in a standardized format. Having monetary rewards in kits should not break based off of a config value oriented around currency display (suffix). Additionally, the dollar sign should be the standard money symbol which works on all servers and should not be tied to the server's individual currency symbol. Note that the server's individual currency symbol will still work but probably should not be used due its volatility.
Simplifies the amount of actions needed to sanitize the input. Now just defaults to `$` if the currency-symbol cannot be parsed.
Member
|
Note to self (or others) of things to test before approval:
|
# Conflicts: # Essentials/src/com/earth2me/essentials/Kit.java # Essentials/src/com/earth2me/essentials/Settings.java # Essentials/src/com/earth2me/essentials/utils/NumberUtil.java
mdcfe
approved these changes
Dec 30, 2020
pop4959
approved these changes
Dec 30, 2020
ressidell
pushed a commit
to ressidell/Essentials
that referenced
this pull request
Apr 27, 2025
* Made currency symbol standardized in Kit * Kits should be in a standardized format. * Having monetary rewards in kits should not break based off of a config value oriented around currency display (suffix). * Additionally, the dollar sign should be the standard money symbol which works on all servers and should not be tied to the server's individual currency symbol. * Note that the server's individual currency symbol will still work but probably should not be used due its volatility. * Reworked config currency symbol parsing in Settings * Simplifies the number of actions needed to sanitize the input. * Now just defaults to `$` if the currency-symbol cannot be parsed. * Removed symbol-suffixed parsing in NumberUtil#sanitizeCurrencyString
rewsdjad1
pushed a commit
to rewsdjad1/EssentialsXPlus
that referenced
this pull request
Aug 13, 2026
* Made currency symbol standardized in Kit * Kits should be in a standardized format. * Having monetary rewards in kits should not break based off of a config value oriented around currency display (suffix). * Additionally, the dollar sign should be the standard money symbol which works on all servers and should not be tied to the server's individual currency symbol. * Note that the server's individual currency symbol will still work but probably should not be used due its volatility. * Reworked config currency symbol parsing in Settings * Simplifies the number of actions needed to sanitize the input. * Now just defaults to `$` if the currency-symbol cannot be parsed. * Removed symbol-suffixed parsing in NumberUtil#sanitizeCurrencyString
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$if the currency-symbol cannot be parsed.