镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Show and copy public keys separately - #6237

Draft
EdgeClaws wants to merge 1 commit into
EdgeApp:developfrom
EdgeClaws:clawdia/xpub-display-keys
Draft

EdgeClaws wants to merge 1 commit into
EdgeApp:developfrom
EdgeClaws:clawdia/xpub-display-keys

Conversation

@EdgeClaws

@EdgeClaws EdgeClaws commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Description

Show every wallet display public key in a dedicated labeled modal with independent accessible copy actions. Multi-key wallets also get Copy All, which copies each visible label and key in display order as a newline-delimited support payload. Known UTXO derivations use reader-facing labels, unknown plugin keys retain their identity, and single-key wallets retain the existing explorer action. EOS, Telos, and WAX keep their established singular-key route instead of introducing a universal plural fallback.

The GUI is temporarily pinned to the exact repaired dependency commits so CI and local builds exercise the real cross-repo contract:

Replace the Git SHA pins with released versions after those PRs publish.

Asana: https://app.asana.com/1/9976422036640/project/1213843652804305/task/1207848254943129?focus=true

Verification

  • Full precommit: 120/120 suites, 964/964 tests, 108/108 snapshots
  • TypeScript and localization checks passed
  • Exact Copy All payload covered by unit tests, including unknown future keys and display order
  • Copy All omitted for single-key wallets
  • Maestro syntax passed; C000047-view-xpub now asserts and taps Copy All
  • Exact pinned Android release APK built, signed, installed, and exercised locally
  • Focused physical-device proof passed on a Motorola Moto G Power (2022), Android 12
  • Bitcoin: real labeled BIP49 ypub + BIP84 zpub; individual copy and Copy All controls exercised
  • Dash: BIP44 drkp
  • Imported Dogecoin: BIP44 dgub
  • Two isolated critical reviews completed; final diff verdict: SHIP

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

@EdgeClaws
EdgeClaws force-pushed the clawdia/xpub-display-keys branch from e9c5106 to a2221e4 Compare October 3, 2026 01:39
@socket-security

socket-security Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatededge-core-js@​2.50.0 ⏵ 2.50.0N/AN/AN/AN/AN/A
Updatededge-currency-plugins@​3.15.0 ⏵ 3.15.0N/AN/AN/AN/AN/A
Updatedreact-native-custom-tabs@​0.1.8N/AN/AN/AN/AN/A
Updatedreact-native-store-review@​0.4.3N/AN/AN/AN/AN/A

View full report

@EdgeClaws
EdgeClaws force-pushed the clawdia/xpub-display-keys branch from a2221e4 to 7d98cb6 Compare October 3, 2026 01:50
Render each available public key in a labeled, copyable modal row while preserving singular-wallet explorer behavior and compatibility with the current core release.
@EdgeClaws
EdgeClaws force-pushed the clawdia/xpub-display-keys branch from 7d98cb6 to 1b82677 Compare October 3, 2026 18:12
@EdgeClaws EdgeClaws changed the title Show public keys separately Show and copy public keys separately Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant