镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Read giftCardInfo from the typed info rollup - #6225

Open
j0ntz wants to merge 1 commit into
developfrom
jon/bundle-info-server-client-entry
Open

j0ntz wants to merge 1 commit into
developfrom
jon/bundle-info-server-client-entry

Conversation

@j0ntz

@j0ntz j0ntz commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Description

Asana task

Bump edge-info-server to 3.14.0 and read giftCardInfo from the typed info rollup.

edge-info-server 3.13.0 could not be bundled. Its entry star-exported the attestation module, which pulled in jose's Node build, and Metro failed to resolve zlib/crypto. 3.14.0 ships the client/Node entry split from EdgeApp/edge-info-server#163: react-native resolves to types.js, which has no jose. Its asInfoRollup also keeps giftCardInfo, so updateGiftCardInfo reads infoServerData.rollup?.giftCardInfo and the rollupRaw copy is deleted.

The GUI keeps its own asGiftCardInfo over the typed field. The info-server NestedDisableMap allows false leaves; the GUI only acts on true.

Testing:

  • iOS and Android react-native bundle both exit 0 on 3.14.0. The 3.13.0 control fails on zlib.
  • The registry 3.14.0 build boots to Home on the iOS sim and on an Android 16 emulator (assembleDebug). On Android debug builds, BlurBackground passes no blurAmount to rn-id-blurview, which trips a dev-mode NaN invariant (code this branch does not touch). The Android frame passes blurAmount locally to get past it (reverted, not in this PR).
  • iOS sim: with giftCardInfo.disablePlugins.phaze = true injected into the raw rollup JSON before asInfoRollup, the Home Spend tile shows the Bitrefill copy and Spend > Purchase New opens Bitrefill. The Phaze fallback from EdgeApp/edge-react-gui#6197 still triggers. Without the injection, the Phaze copy shows.
  • tsc has only the pre-existing edge-core-js disklet type error. Lint is clean and jest passes 107 suites / 842 tests.

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Medium Risk
The bump changes how info-server rollup data is parsed and how Phaze/Bitrefill remote disable flags reach the UI; mis-parsing would show the wrong spend provider, but scope is limited to gift-card config rather than keys or sends.

Overview
Upgrades edge-info-server from 3.12.0 to 3.14.0, unblocking typed info rollup fields that older cleaners dropped and avoiding the 3.13 Metro bundling failure (attestation/jose Node paths).

Gift card remote config now loads from infoServerData.rollup?.giftCardInfo via the existing asGiftCardInfo cleaner, instead of parsing a parallel rollupRaw payload. The rollupRaw store and related comments in initInfoServer are removed so all consumers use the cleaned InfoRollup.

Reviewed by Cursor Bugbot for commit 0704ff1. Bugbot is set up for automated code reviews on this repo. Configure here.

Test evidence

0704ff1
Read giftCardInfo from the typed info rollup
2026-09-27
🪓 01-03: network.ts injected giftCardInfo={disablePlugins:{phaze:true}} into raw rollup JSON before asInfoRollup; 05: BlurBackground passed blurAmount to skip a pre-existing Android dev-mode NaN invariant; all reverted

1. 🪓 home spend tile bitrefill footer

2. 🪓 edgespend list readonly

3. 🪓 purchase new opens bitrefill

4. control no injection phaze footer

5. 🪓 android home boots on 3140

6. ios home boots on 3140

edge-info-server 3.14.0 serves a client entry without the attestation
module, so Metro no longer tries to bundle jose's Node build. Its
asInfoRollup also keeps giftCardInfo, so the raw rollup copy that only
existed to read that key is gone.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatededge-info-server@​3.12.0 ⏵ 3.14.078 +910091 +192 +2100

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant