Repository navigation
Conversation
edge-info-server 3.14.0 serves a client entry without the attestation module, so Metro no longer tries to bundle jose's Node build. Its asInfoRollup also keeps giftCardInfo, so the raw rollup copy that only existed to read that key is gone.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Asana task
Bump edge-info-server to 3.14.0 and read
giftCardInfofrom the typed info rollup.edge-info-server 3.13.0 could not be bundled. Its entry star-exported the attestation module, which pulled in jose's Node build, and Metro failed to resolve
zlib/crypto. 3.14.0 ships the client/Node entry split from EdgeApp/edge-info-server#163:react-nativeresolves totypes.js, which has no jose. ItsasInfoRollupalso keepsgiftCardInfo, soupdateGiftCardInforeadsinfoServerData.rollup?.giftCardInfoand therollupRawcopy is deleted.The GUI keeps its own
asGiftCardInfoover the typed field. The info-serverNestedDisableMapallowsfalseleaves; the GUI only acts ontrue.Testing:
react-native bundleboth exit 0 on 3.14.0. The 3.13.0 control fails onzlib.assembleDebug). On Android debug builds,BlurBackgroundpasses noblurAmountto rn-id-blurview, which trips a dev-mode NaN invariant (code this branch does not touch). The Android frame passesblurAmountlocally to get past it (reverted, not in this PR).giftCardInfo.disablePlugins.phaze = trueinjected into the raw rollup JSON beforeasInfoRollup, the Home Spend tile shows the Bitrefill copy and Spend > Purchase New opens Bitrefill. The Phaze fallback from EdgeApp/edge-react-gui#6197 still triggers. Without the injection, the Phaze copy shows.disklettype error. Lint is clean and jest passes 107 suites / 842 tests.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Medium Risk
The bump changes how info-server rollup data is parsed and how Phaze/Bitrefill remote disable flags reach the UI; mis-parsing would show the wrong spend provider, but scope is limited to gift-card config rather than keys or sends.
Overview
Upgrades
edge-info-serverfrom 3.12.0 to 3.14.0, unblocking typed info rollup fields that older cleaners dropped and avoiding the 3.13 Metro bundling failure (attestation/joseNode paths).Gift card remote config now loads from
infoServerData.rollup?.giftCardInfovia the existingasGiftCardInfocleaner, instead of parsing a parallelrollupRawpayload. TherollupRawstore and related comments ininitInfoServerare removed so all consumers use the cleanedInfoRollup.Reviewed by Cursor Bugbot for commit 0704ff1. Bugbot is set up for automated code reviews on this repo. Configure here.
Test evidence
0704ff1Read giftCardInfo from the typed info rollup
2026-09-27
🪓 01-03: network.ts injected giftCardInfo={disablePlugins:{phaze:true}} into raw rollup JSON before asInfoRollup; 05: BlurBackground passed blurAmount to skip a pre-existing Android dev-mode NaN invariant; all reverted
1. 🪓 home spend tile bitrefill footer
2. 🪓 edgespend list readonly
3. 🪓 purchase new opens bitrefill
4. control no injection phaze footer
5. 🪓 android home boots on 3140
6. ios home boots on 3140