镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Fix data-streams synchronization in instrumentation tests - #13283

Open
amarziali wants to merge 1 commit into
masterfrom
andrea.marziali/fix-datastreams-test-races
Open

amarziali wants to merge 1 commit into
masterfrom
andrea.marziali/fix-datastreams-test-races

Conversation

@amarziali

Copy link
Copy Markdown
Contributor

What Does This Do

Make data-streams resets wait for previously queued work and pending payload writes before clearing the recording writer. Polling now uses the same instance lock as payload writes.

Note: while production code is touched, the clear method is only called by test code (reason why has been documented with a @VisibleForTest annotation)

Motivation

Four Vert.x 5 tests timed out waiting for data-streams statistics in CI jobs, then passed on retry. Investigation exposed concurrent bucket-map resets and unsynchronized reads in the test harness.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali
amarziali requested review from a team as code owners November 6, 2026 13:47
@amarziali amarziali added the type: bug fix Bug fix label Nov 6, 2026
@amarziali
amarziali removed the request for review from a team November 6, 2026 13:47
@amarziali amarziali added the comp: testing Testing label Nov 6, 2026
@amarziali amarziali added the tag: no release notes Changes to exclude from release notes label Nov 6, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T13:49:35.090129Z 88d7c40 PR opened
🔒 Security Review ✅ Completed 2026-11-06T13:50:31.840739Z 88d7c40 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-us1-prod datadog-datadog-us1-prod Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

Queued resets serialize bucket clearing with earlier consumer work, and payload polling now shares the writer’s instance lock. No actionable defect was identified through static inspection; runtime concurrency behavior was not exercised.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 88d7c40

@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

🎯 Code Coverage (details)
• Patch Coverage: 31.58%
• Overall Coverage: 61.15% (+1.17%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 88d7c40 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.09 s 14.00 s [-0.3%; +1.5%] (no difference)
startup:insecure-bank:tracing:Agent 12.95 s 13.03 s [-1.3%; +0.0%] (no difference)
startup:petclinic:appsec:Agent 17.16 s 16.97 s [+0.2%; +2.1%] (maybe worse)
startup:petclinic:iast:Agent 17.06 s 17.19 s [-1.5%; +0.1%] (no difference)
startup:petclinic:profiling:Agent 16.69 s 16.84 s [-1.9%; +0.1%] (no difference)
startup:petclinic:sca:Agent 17.18 s 16.97 s [+0.4%; +2.1%] (maybe worse)
startup:petclinic:tracing:Agent 16.20 s 16.20 s [-1.1%; +1.1%] (no difference)

Commit: 88d7c40e · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testing Testing tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant