镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Avoid redundant continuation capture for Resilience4j callbacks - #13273

Draft
amarziali wants to merge 1 commit into
andrea.marziali/openai-callback-exclusionfrom
andrea.marziali/resilience4j-callback-exclusion
Draft

amarziali wants to merge 1 commit into
andrea.marziali/openai-callback-exclusionfrom
andrea.marziali/resilience4j-callback-exclusion

Conversation

@amarziali

Copy link
Copy Markdown
Contributor

What Does This Do

Skip redundant continuation capture for Resilience4j’s agent-owned completion callbacks.

Motivation

The completion callback already owns the tracing wrapper that finishes the span, so it does not need another captured continuation.

Additional Notes

Use a named span-finishing callback for CompletionStage and CompletableFuture results and exclude its exact class.

Stacked on #13272; targets andrea.marziali/openai-callback-exclusion.

@amarziali amarziali added tag: ai generated Largely based on code generated by an AI or LLM type: refactoring comp: core Tracer core tag: no release notes Changes to exclude from release notes labels Nov 6, 2026 — with ChatGPT Codex Connector
@amarziali amarziali removed the tag: no release notes Changes to exclude from release notes label Nov 6, 2026
@amarziali
amarziali added this pull request to stack #13264 November 6, 2026 07:41
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 63.39% (-0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2c4fca3 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.75 s 14.72 s [-0.7%; +1.1%] (no difference)
startup:insecure-bank:tracing:Agent 13.58 s 13.65 s [-1.4%; +0.3%] (no difference)
startup:petclinic:appsec:Agent 17.67 s 17.50 s [+0.2%; +1.8%] (maybe worse)
startup:petclinic:iast:Agent 17.51 s 17.59 s [-1.5%; +0.6%] (no difference)
startup:petclinic:profiling:Agent 16.80 s 16.89 s [-6.5%; +5.5%] (unstable)
startup:petclinic:sca:Agent 17.53 s 17.07 s [-1.9%; +7.2%] (no difference)
startup:petclinic:tracing:Agent 16.35 s 16.81 s [-7.0%; +1.6%] (no difference)

Commit: 2c4fca3b · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@amarziali
amarziali force-pushed the andrea.marziali/resilience4j-callback-exclusion branch from 63edbeb to 2c4fca3 Compare November 6, 2026 10:21
@dd-octo-sts

dd-octo-sts Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

❌ New Groovy Files Detected

Please avoid introducing new .groovy files to this repository.

  • dd-java-agent/instrumentation/resilience4j/resilience4j-2.0/src/test/groovy/Resilience4jCallbackExclusionTest.groovy

Instead, rewrite the new file(s) in Java / JUnit. See the How to Test With JUnit Guide for more details.

If this PR needs an exception, add the tag: override groovy enforcement label to bypass this workflow.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: core Tracer core tag: ai generated Largely based on code generated by an AI or LLM type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant