assertThrows raise an exception about mismatching messages

There is an example to reproduce:

$this->assertThrows(Exception::class, function () {
    throw new Exception('an exception');
});

exception message '' was expected, but 'an exception' was received

fix Codeception#4. assertThrow: do not raise an exception when messag…

confirmed. Your fix is valid :) Was about to send a similar PR.

Confirmed. Facing the same problem here.
I will use old version of specify package which does not use this package while this PR is waiting for merge.

Accepting this PR would really be appreciated!

@DavertMik

@DavertMik please have a look at this.

Confirmed! Running into the very same issue. Will be fixed with the proposed PR.

Confirmed, please have a look soon, it's already been quite long when PR is already available.

@DavertMik

@DavertMik
@diego-vieira

                  🐞 
             🐝 🐝 🐝 
       🐝 🐝 🐝 🐝 🐝 
  🐝 🐝 🐝 🐝 🐝 🐝 🐝

Waiting for this PR too...

Confirmed as well! Please can we get this PR merged asap. This is becoming a roadblock in our team flow 😞

In the meantime, I wrapped all the assertion stuff in a try-catch block like the following:

$this->it(
    "throws an exception",
    function () {
        $this->assertThrows(
            \InvalidArgumentException::class,
            function () {
                try {
                    $this->unitUnderTest->functionUnderTest($param);
                } catch (\InvalidArgumentException $e) {
                     throw new \InvalidArgumentException();
                }
            }
        );
    }
);

This just strips the message from the exception. It's ugly and shouldn't be needed, but it does the trick until the PR is merged.

@DavertMik

@DavertMik is there a reason this issue is neglected? If the library is no longer maintained, wouldn't it make sense to say so in the README?

Merge pull request #5 from askobara/fix-exception-when-mismatched

Navigation Menu

Repository navigation

assertThrows raise an exception about mismatching messages #4

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

assertThrows raise an exception about mismatching messages #4

Description

Activity

wmathes commented on Feb 22, 2018

ppetpadriew commented on Feb 23, 2018

kagje commented on Feb 28, 2018

wmathes commented on Mar 5, 2018

Solomonic commented on Mar 5, 2018

cyberhck commented on Mar 5, 2018

z3niths commented on Mar 5, 2018

Lewke commented on Mar 6, 2018

theoc31 commented on Mar 7, 2018

barthy-koeln commented on Jul 12, 2018

ddinchev commented on Dec 28, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions