✨ Improve Design Implementation for Find in File #3

Activity

1. austincondiff

   changed the title [-]Improve Design for Find in File[/-] [+]✨ Improve Design for Find in File[/+] on Oct 6, 2022
2. austincondiff

   changed the title [-]✨ Improve Design for Find in File[/-] [+]✨ Improve Design Implementation for Find in File[/+] on Oct 6, 2022
3. lukepistrol

   added

   enhancementNew feature or requestNew feature or request

   on Nov 22, 2022
4. austincondiff commented on Feb 16, 2023

   

   austincondiff

   on Feb 16, 2023

   ContributorAuthor

   More actions

   Are there any standard input styles we can use for this or will we need to create this custom?
5. austincondiff

   self-assigned this

   on Feb 16, 2023
6. thecoolwinter commented on Feb 17, 2023

   

   thecoolwinter

   on Feb 17, 2023

   Contributor

   More actions

   The one in CE right now is the default NSTextFinder, we'll need to create a custom one.
7. luah5 commented on Apr 11, 2023

   

   luah5

   on Apr 11, 2023

   Member

   More actions

   @thecoolwinter Is it in CE, CETV or STTextView? It seems like STTextView (prove me wrong) has this file for find/replace, meaning that we need to override this in base CE (again, i might be wrong).
8. thecoolwinter commented on Apr 11, 2023

   

   thecoolwinter

   on Apr 11, 2023

   Contributor

   More actions

   The file you sent is extending STTextView to support NSTextFinder, not implementing a custom finder.
9. luah5 commented on Apr 11, 2023

   

   luah5

   on Apr 11, 2023

   Member

   More actions

   Ok i get it, so you're suggesting that we create a custom Find/Replace in CETV. But, considering that the find/replace is in this file in CE shouldn't the custom view be created in CE (or am i just making a incorrect point), @thecoolwinter?
10. thecoolwinter commented on Apr 11, 2023

    

    thecoolwinter

    on Apr 11, 2023

    Contributor

    More actions

    That command sends a showFindPanel message down to the first active view that can respond to it. If you go into CE rn and press command F in the editor you'll get a find menu.

    This issue is saying the UI part for entering text to find should be custom. Because that finder view needs to be installed on the STTextView, it has to be implemented in CETV where that view can be accessed.

    👍React with 👍1Reacted by luah5
11. austincondiff

    transferred this issue fromCodeEditApp/CodeEditSourceEditoron Dec 20, 2023
12. LeoBorai

    added a commit that references this issue on Feb 12, 2024

    Merge pull request #3 from lukepistrol/main

    ...

    dc48745
13. thecoolwinter

    closed this as completedin CodeEditSourceEditor#295on Apr 8, 2025
14. thecoolwinter

    added a commit that references this issue on Apr 8, 2025

    feat: Find in Editor (#295)

    ...

    f444927
15. github-project-automation

    moved this from 📋 Todo to 🏁 Complete in CodeEdit Projecton Apr 8, 2025