You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
🐞 Line height decreases when no characters exist on line #20
@ben-p-commits I believe the problem was caused when I decreased the font size of the line numbers. Because there is no text, the line collapses on the tallest item which is the smaller line number after removing the last character of the larger code. We may need a minimum height on each line or set the line height of the line number to be equal to the line height of the code.
Activity
[-]Line height incorrect.[/-][+]🐞 Line height incorrect.[/+]ben-p-commits commentedon Jan 18, 2023
@austincondiff , i'll take this one, I'm having fun poking at CETV lately :)
lukepistrol commentedon Jan 18, 2023
@ben-p-commits assigned it to you
ben-p-commits commentedon Jan 18, 2023
After doing some digging, I do see a code path for handling the empty text container case when laying out the
STLineNumberRulerViewin STTextViewI'm not seeing this bug in the sample app embedded in the dependency... a good sign we can fix this on our end.
ben-p-commits commentedon Jan 18, 2023
Also confirmed that pulling in the latest
mainbranch work on STTextView doesn't address this.ben-p-commits commentedon Jan 18, 2023
@krzyzanowskim - do you have any thoughts on how our usage of STTextView could be causing this?
I'm stumped. Not sure how our code is influencing this...
austincondiff commentedon Feb 16, 2023
@ben-p-commits I believe the problem was caused when I decreased the font size of the line numbers. Because there is no text, the line collapses on the tallest item which is the smaller line number after removing the last character of the larger code. We may need a minimum height on each line or set the line height of the line number to be equal to the line height of the code.
[-]🐞 Line height incorrect.[/-][+]🐞 Line height decreases when no characters exist on line[/+]luah5 commentedon Mar 29, 2023
a slight edit to #170 could fix this issue.
austincondiff commentedon Mar 29, 2023
@luah5 Did you want to take this one then?
luah5 commentedon Mar 29, 2023
i've barely looked into this but i'll take it, also CETV needs to be updated.
luah5 commentedon Apr 25, 2023
This might have something to do with @Eliulm's message where he pointed out that the line height overlaps a bit.
thecoolwinter commentedon Dec 9, 2023
This has been resolved with #211.
Screen.Recording.2023-12-09.at.3.09.04.PM.mov
Fix CRLF Line Ending Typesetting (CodeEditApp#20)