Fix animation (#45)

[0xWDG]

No description provided.

[lukepistrol]

This is actually required since in a very large project folder this will load all children all the time which leads to very long file opening times.

[lukepistrol]

Screen.Recording.2022-03-18.at.15.59.15.mov

[0xWDG]

It breaks the animation.

Maybe it's an idea to only place the labels, and then update them?

[lukepistrol]

If you can figure something out that doesn't break performance that'd be awesome. So far this if clause was the best option I found

[0xWDG]

So instead of

SideBarItem(item: child,
workspace: workspace,
windowController: windowController)

We should use?

SideBarItem(item: child,
workspace: workspace,
windowController: windowController,
loadSubitems: isExpanded)

Or (maybe the worst solution)

Text(child.name) // Don't know is child.name exists. its pseudo code

[0xWDG]

Ah, I see, the issue is, when you open a file, it's rendering the whole file tree again.

This should

1. be done on the background
2. or not at all when opening a file

[lukepistrol]

That's what I suspected as well

[lukepistrol]

ok I just tested the latest commit and it seems to run very nice. Couldn't see performance losses to before.

[0xWDG]

Ok, after some research, opening/closing doesn't trigger an update.
selecting a file does.

There seems to be a delay again when opening files from that video

This has been fixed with commit 6dfa149

6dfa149 (for refrerence, clickable)

This commit increases the speed, but this is not the solution, the problem is that this bar is getting re-rendered when you open/select a file.
if you disable this if, and only open and close the disclosure groups, then it works as expected.

[lukepistrol]

SwiftUI acts strangely sometimes…

[lukepistrol]

Something you might want to have a look at:
When opening a file in a subfolder, and then collapsing the subfolder, the editor will disappear.

[austincondiff]

There seems to be a delay again when opening files from that video

[lukepistrol]

There seems to be a delay again when opening files from that video

This has been fixed with commit 6dfa149

[0xWDG]

I'm closing this pull request.
it requires someone with more SwiftUI experience, or need some more time to figure out.
I'm first going to help on other issues.