New implementation of Project Navigator - Performance Improvements by lukepistrol · Pull Request #411 · CodeEditApp/CodeEdit

lukepistrol · 2022-04-06T14:55:07Z

Description

This is still WIP.

I implemented a NSViewControllerRepresentable hosting a NSOutlineView in order to fix performance issues on very large folders.

As you can see below there are no delays at all when unfolding a folder which took up to a couple of seconds as discussed here: #395.

TODOs:

UI fine adjustments
context menu (right click)
Documentation

Out of scope for now:

Reload list when folder content changes

Related Issue

🐞 Folder opening time #395

Checklist

I read and understood the contributing guide as well as the code of conduct
My changes generate no new warnings
My code builds and runs on my machine
Review requested

Screenshots

Screen.Recording.2022-04-07.at.11.19.54.mov

# Conflicts: # CodeEdit.xcodeproj/project.pbxproj # CodeEdit/Info.plist

This reverts commit 8016521, reversing changes made to 1d8e6bc.

0xWDG · 2022-04-06T15:00:37Z

Looks great @lukepistrol!

Angelk90 · 2022-04-06T15:41:17Z

@lukepistrol : Ok, I got to test it seems to work fine.

I would like to hear @RayZhao1998 opinion, I could take a look at the statistics.
Understanding when the situation has improved compared to before.

RayZhao1998 · 2022-04-06T16:55:04Z

It looks great!

…gator Size` (row height)

RayZhao1998 · 2022-04-07T14:03:09Z

I've tested this. It's awesome!

A little bug: if I open a file whose folder is not expanded from breadcrumbs, the selection state will not change.
For example. .all-contributorsrc has been opened. Now I open .circleci/config.yml from breadcrumbs and .circleci is not expanded. The selection is still .all-contributorsrc.

nanashili

I don't see any issues. Looks good @lukepistrol

RayZhao1998 · 2022-04-08T13:47:10Z

When I open a new project, the workspace folder is not expanded by default now. Also workspace icon color is missing.

RayZhao1998 · 2022-04-08T13:57:32Z

+        if row == -1 {
+            outlineView.deselectRow(outlineView.selectedRow)
+        }
+        outlineView.selectRowIndexes(.init(integer: row), byExtendingSelection: false)


I did a quick experiment. You can do like this to expand current selection file's folder.

var parent = item.parent while parent != nil { outlineView.expandItem(parent) parent = parent?.parent }

Yeah it works great but it introduces another problem: When you collapse the folder of the selected item and then expand another folder, the folder of the selected item gets expanded as well.

I think I'll leave it for now and we can figure something out in a later PR.

lukepistrol · 2022-04-08T14:12:13Z

When I open a new project, the workspace folder is not expanded by default now.

I mean Xcode does this too when fist opening a project you never opened before. But I can change it to auto expand the first level.

lukepistrol · 2022-04-08T14:37:41Z

@lukepistrol : Is there a possibility to have the icons and text similar in size to that of xcode?

It actually is the exact size

At the moment it appears that the following implementation is not supported.

Yeah I know

Angelk90 · 2022-04-08T14:41:27Z

@lukepistrol :

Some considerations:

Is there a possibility to have the icons and text similar in size to that of xcode?

At the moment it appears that the following implementation is not supported.

When you switch from one file to another, you will see the selected file in the left sidebar if the folder is open.
Instead of being the same color as the selection (blue in my case), it could be a different color gray to mean a different value, like xcode does.

Registrazione.schermo.2022-04-08.alle.16.35.10.mov

Registrazione.schermo.2022-04-08.alle.16.39.25.mov

Now it has also stopped working properly.

Registrazione.schermo.2022-04-08.alle.16.43.25.mov

lukepistrol · 2022-04-08T14:43:57Z

When you switch from one file to another, you will see the selected file in the left sidebar if the folder is open.
Instead of being the same color as the selection (blue in my case), it could be a different color gray to mean a different value, like xcode does.

This is because the editor view is not becoming first responder once a file is opened. Not in scope of the project navigator!

Angelk90 · 2022-04-08T14:53:39Z

@lukepistrol : This happens to me, the elements no longer keep the selection, see both videos.

Registrazione.schermo.2022-04-08.alle.16.47.51.mov

Continue:

Registrazione.schermo.2022-04-08.alle.16.52.30.mov

lukepistrol · 2022-04-08T15:38:40Z

@Angelk90 selection should now work as expected

Angelk90 · 2022-04-08T15:47:32Z

@lukepistrol : Seems not to be a problem at the moment.
To have the bigger icons, would it be to have this thing in the settings?

nanashili · 2022-04-08T16:11:11Z

How do you guys get bugs but when I test it it's fine?!

lukepistrol · 2022-04-08T16:14:43Z

How do you guys get bugs but when I test it it's fine?!

They only occurred when you opened files, then closed them all together and then reopened a file. Was a small recursion problem 😄

Angelk90 · 2022-04-08T16:37:16Z

How do you guys get bugs but when I test it it's fine?!

@nanashili : There we invent them. 😂

RayZhao1998

LGTM! It's awesome!

lukepistrol added 4 commits April 6, 2022 16:32

implementing NSOutlineView as project navigator

5bd1514

Merge branch 'main' into bug/proj-nav-outline-view

8016521

# Conflicts: # CodeEdit.xcodeproj/project.pbxproj # CodeEdit/Info.plist

Revert "Merge branch 'main' into bug/proj-nav-outline-view"

6a42878

This reverts commit 8016521, reversing changes made to 1d8e6bc.

fixes bugs

460d66f

lukepistrol added bug Something isn't working performance This is performance related navigator labels Apr 6, 2022

lukepistrol self-assigned this Apr 6, 2022

lukepistrol mentioned this pull request Apr 6, 2022

🐞 Folder opening time #395

Closed

lukepistrol added the WIP This is work-in-progress label Apr 6, 2022

lukepistrol added 7 commits April 7, 2022 01:56

refactoring, added context menu

1a78aca

UI adjustments, added top level project folder, preparation for `Navi…

dabd2cc

…gator Size` (row height)

fixed alignment issues

9a3591e

Merge branch 'main' into bug/proj-nav-outline-view

3fa795b

reverted alignment adjustments

1a5ea41

fixed contentInsets.top

0d41ffe

added documentation

742f667

lukepistrol requested review from MarcoCarnevali, RayZhao1998 and austincondiff April 7, 2022 09:58

lukepistrol marked this pull request as ready for review April 7, 2022 09:58

lukepistrol changed the title ~~[WIP] New implementation of Project Navigator - Performance Improvements~~ New implementation of Project Navigator - Performance Improvements Apr 7, 2022

lukepistrol removed the WIP This is work-in-progress label Apr 7, 2022

RayZhao1998 reviewed Apr 7, 2022

View reviewed changes

Comment thread CodeEdit/NavigatorSidebar/ProjectNavigator/OutlineView/OutlineViewController.swift Outdated

RayZhao1998 reviewed Apr 7, 2022

View reviewed changes

Comment thread CodeEdit/NavigatorSidebar/ProjectNavigator/OutlineView/OutlineViewController.swift Outdated

lukepistrol marked this pull request as draft April 7, 2022 15:00

lukepistrol and others added 3 commits April 7, 2022 17:18

fixed suggestions, fixed selection

00546fc

Merge branch 'CodeEditApp:main' into bug/proj-nav-outline-view

51d3385

folders now keep expanded across sessions

44a8eec

lukepistrol marked this pull request as ready for review April 8, 2022 13:08

lukepistrol requested review from RayZhao1998 and nanashili April 8, 2022 13:08

lukepistrol changed the title ~~[WIP] New implementation of Project Navigator - Performance Improvements~~ New implementation of Project Navigator - Performance Improvements Apr 8, 2022

lukepistrol removed the WIP This is work-in-progress label Apr 8, 2022

nanashili approved these changes Apr 8, 2022

View reviewed changes

RayZhao1998 reviewed Apr 8, 2022

View reviewed changes

fixed spacing, fixed selection related bugs

353e535

lukepistrol added 2 commits April 8, 2022 18:00

auto expand zip level folder

24de3e8

removed print statements

17444dc

lukepistrol requested a review from RayZhao1998 April 8, 2022 16:11

fixed docs

83926b0

RayZhao1998 approved these changes Apr 8, 2022

View reviewed changes

lukepistrol removed request for MarcoCarnevali and austincondiff April 8, 2022 17:01

lukepistrol merged commit 8be6e8f into CodeEditApp:main Apr 8, 2022

Conversation

lukepistrol commented Apr 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

TODOs:

Out of scope for now:

Related Issue

Checklist

Screenshots

Uh oh!

0xWDG commented Apr 6, 2022

Uh oh!

Angelk90 commented Apr 6, 2022

Uh oh!

RayZhao1998 commented Apr 6, 2022

Uh oh!

Uh oh!

Uh oh!

RayZhao1998 commented Apr 7, 2022

Uh oh!

nanashili left a comment

Choose a reason for hiding this comment

Uh oh!

RayZhao1998 commented Apr 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RayZhao1998 Apr 8, 2022

Choose a reason for hiding this comment

Uh oh!

lukepistrol Apr 8, 2022

Choose a reason for hiding this comment

Uh oh!

lukepistrol Apr 8, 2022

Choose a reason for hiding this comment

Uh oh!

lukepistrol commented Apr 8, 2022

Uh oh!

lukepistrol commented Apr 8, 2022

Uh oh!

Angelk90 commented Apr 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukepistrol commented Apr 8, 2022

Uh oh!

Angelk90 commented Apr 8, 2022

Uh oh!

lukepistrol commented Apr 8, 2022

Uh oh!

Angelk90 commented Apr 8, 2022

Uh oh!

nanashili commented Apr 8, 2022

Uh oh!

lukepistrol commented Apr 8, 2022

Uh oh!

Angelk90 commented Apr 8, 2022

Uh oh!

RayZhao1998 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lukepistrol commented Apr 6, 2022 •

edited

Loading

RayZhao1998 commented Apr 8, 2022 •

edited

Loading

Angelk90 commented Apr 8, 2022 •

edited

Loading