镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

🐞 Open folder crash #677

Closed
Closed

Description

@thunur

Description

When the open folder contains node_ Modules will cause codeedit to crash
image

To Reproduce

  1. Open folder with more than 45530 files

Expected behavior

Read file normally

Version information

CodeEdit: ##1.0
MacOS: 12.4
Xcode: 13.4.1

Additional context

No response

Activity

  1. 0xWDG commented on Jun 27, 2022

    @0xWDG
    Collaborator

    How many sub-folders are there in the folder?
    This code only loops for folders.

  2. austincondiff commented on Jun 28, 2022

    @austincondiff
    Collaborator

    node_modules could contain hundreds or even thousands of folders depending on the project size.

  3. thunur commented on Jun 28, 2022

    @thunur
    Author

    How many sub-folders are there in the folder? This code only loops for folders.

    ls -lR | grep -c "^-"
    Through this command, the output result is 71388

  4. thunur commented on Jun 28, 2022

    @thunur
    Author

    node_modules could contain hundreds or even thousands of folders depending on the project size.

    Of course, as an excellent editor, I think it should support projects of different sizes. I like codeedit very much and hope it can be better

  5. KaiTheRedNinja commented on Jul 9, 2022

    @KaiTheRedNinja
    Contributor

    What is the error exactly? I can’t see it from your image. This code is not optimized, for every change in the file system it re-indexes EVERY FILE, which does cause issues in such a large folder. I can work on a PR to fix this issue since I was the most recent person to work on this code.

  6. KaiTheRedNinja commented on Jul 10, 2022

    @KaiTheRedNinja
    Contributor

    I am able to reproduce the error with a NextJS project, I will work on this.

  7. KaiTheRedNinja commented on Jul 10, 2022

    @KaiTheRedNinja
    Contributor

    it appears that it is an issue with using the open file too many times. The program consistently crashes the open after open returns 2559 (a file id i think? I have no clue), where open returns -1 and causes a crash.
    image

  8. moved this from 🆕 New to 🏁 Complete in CodeEdit Projecton Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions