Repository navigation
Conversation
juntyr
left a comment
There was a problem hiding this comment.
Thanks! LGTM, I just had a few questions and small nits
| "dask~=2024.12.0", | ||
| "fsspec~=2024.10.0", | ||
| "healpy~=1.18.0", | ||
| "intake==0.7.0", |
There was a problem hiding this comment.
Why are the intake version bounds strictly pinned?
There was a problem hiding this comment.
The NextGEMS catalog at "https://data.nextgems-h2020.eu/online.yaml" does not seem to be compatible with any other version. The NextGEMS people I've talked to specifically mentioned that I need to use these version bounds (I don't have any more details though).
There was a problem hiding this comment.
Could you please add a comment here so we don't forget the reason later?
| "intake==0.7.0", | ||
| "intake-xarray==0.7.0", | ||
| "requests~=2.32.3", | ||
| "setuptools~=75.8.2", |
There was a problem hiding this comment.
What are we using setuptools for?
There was a problem hiding this comment.
intake-xarray is requiring setuptools. They probably haven't specified their Python version bounds precisely. So I needed to add setuptools to deal with a No module named 'distutils' error caused by the intake-xarray library.
There was a problem hiding this comment.
Could you add a comment here so we don't forget the reason later?
juntyr
left a comment
There was a problem hiding this comment.
Just a very minor nit left, feel free to merge afterwards!
| "dask~=2024.12.0", | ||
| "fsspec~=2024.10.0", | ||
| "healpy~=1.18.0", | ||
| "intake==0.7.0", |
There was a problem hiding this comment.
Could you please add a comment here so we don't forget the reason later?
| "intake==0.7.0", | ||
| "intake-xarray==0.7.0", | ||
| "requests~=2.32.3", | ||
| "setuptools~=75.8.2", |
There was a problem hiding this comment.
Could you add a comment here so we don't forget the reason later?
|
Great, thanks a lot for the review @juntyr ! Merging now. |
This is adding the functionality to download the publicly available NextGEMS ICON data. This can be used as a replacement of the DYAMOND datasets discussed in #10 . The NextGEMS simulations are using more recent model versions so are preferrable to DYAMOND anyway.