Repository navigation
Patch v0.11.1 - #3306
Open
chernser wants to merge 2 commits into
Open
Patch v0.11.1#3306chernser wants to merge 2 commits into
chernser wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport PR #3303 and #3305
Checklist
Delete items not relevant to your PR:
Note
Low Risk
Localized compression buffer sizing fix with no public API changes beyond correct behavior; slightly larger per-stream buffers is expected.
Overview
Fixes client-v2
INSERTfailures whencompressClientRequest(true)is on and a full 64 KiB block does not shrink under LZ4 or ZSTD (e.g. random data), which previously threwmaxDestLen is too small/ destination buffer too small because the compressed buffer matched the uncompressed block size.The base
CompressedBlockOutputStreamnow takes an explicit max compressed buffer size; LZ4 and ZSTD subclasses set it viaLZ4Compressor.maxCompressedLengthandZstd.compressBoundinstead of assuming compressed output never exceeds the input block. New round-trip tests cover full-block compressible and incompressible payloads for both codecs, and CHANGELOG documents the 0.11.0 regression (#3302).Reviewed by Cursor Bugbot for commit 822d6b5. Bugbot is set up for automated code reviews on this repo. Configure here.