镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

[logging] Review Logging #3295

Open
Open

Description

@chernser

Description

While some of tests we have found that there are places where debug is not required and causes a lot of logs.

For example

What should be done:

  • review all debug logs
  • remove debug logs on hot path (while data reading, while repeating operations)
  • check debug do not have SQL, credentials, sensitive information, user data, etc.
  • review all other logs in the same way
  • info log should be less frequent and happen only 1 - 2 times. info logs should indicate really valuable information not just "client initialized". No configuration dumps. Only very specific cases (because when client initialized for each request it causes log flood)
  • error for exceptions and really errors
  • trace log should not be used except for a few cases
  • warn is to indicate abnormal state. should not happen on hot path but fine for configuration.
  • document logging with examples how to disable/enable different loggers - so user just copy to application configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions