镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

What is the use of 'shaded jar' #1134

Description

@KerwinAusten

Hello, I found there are three shaded jar in clickhouse-jdbc, like this
image

The shaded jar brings about some inconvenience —— it can't download sources so I can't see the code comment and the code jump is also invalid. Now it's hard to debug in my application.

In my opinion, shaded jar always used to prevent dependency conflict in other libraries, but they just shaded third party code, their own module code won't be shaded.

So what's the reason you shaded all the code include your own modules?Can it change to just shade the third party code?😁

Activity

  1. KerwinAusten commented on Nov 24, 2022

    @KerwinAusten
    Author

    The shaed jar also has duplicated class like this
    image

    I see the document let's us to exclude all the dependencies in , but why not abandon shaded jar like other general maven project?

  2. zhicwu commented on Nov 24, 2022

    @zhicwu
    Contributor

    Hi @IcebergXTY, thanks for pointing this out. The shaded jars were only used to reduce dependency exclusions when building JDBC driver, which is messy. Will update pom to fix this.

  3. added this to the 0.4.0 release milestone on Jan 19, 2023
  4. zhicwu commented on Jan 29, 2023

    @zhicwu
    Contributor

    Re-open as the shaded jar does not contain source for debugging.

  5. reopened this on Jan 29, 2023
  6. linked a pull request that will close this issuecreate source jar and update examples #1217on Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions