镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Show confirmation when adding a YouTube/Vimeo link - #3977

Open
scott2068 wants to merge 1 commit into
ChurchApps:mainfrom
scott2068:fix/player-add-feedback
Open

scott2068 wants to merge 1 commit into
ChurchApps:mainfrom
scott2068:fix/player-add-feedback

Conversation

@scott2068

Copy link
Copy Markdown
Contributor

Problem

In Media › Online › Add, pasting a YouTube/Vimeo link saves the video right away, but the popup gives no sign of it. The new entry is hidden behind the popup and the only way out is the X, so it looks like nothing happened. Invalid input was also saved as a broken entry.

Changes (main/popups/CreatePlayer.svelte)

  • Once a link is added, shows a card with the thumbnail, "✓ Added to Media > Online" and the video title.
  • Shows a toast with the same message.
  • Adds a Done button to close the popup.
  • Checks the ID (YouTube: 11-character ID, Vimeo: numeric) and shows an error instead of saving invalid input.
  • Locks the ID field after adding, so a second paste can't overwrite the entry.
  • New strings media.player_added and media.player_invalid in en.json.

Testing (macOS, npm start)

Added YouTube links through the popup: the confirmation card, toast and Done button appear, and the video is listed in Media › Online.

🤖 Generated with Claude Code

The add-link popup saved the video silently behind the popup. Now it
validates the ID, shows a thumbnail + "Added to Media > Online" card,
toasts, and offers a Done button.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant