Repository navigation
Conversation
togglePlayingMedia ran player ids through getMedia, which treats them as local files, fails to locate them and returns early. The video never output, so Next stayed stuck on the item and never advanced. Player items are now output by id, the same way the play button in VideoShow does it. Links dropped directly onto a project were stored with a "-" placeholder id. They are now added to Online media and referenced by that id; older "-" items are migrated the first time they are played. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a YouTube/Vimeo video is added to a project as its own item, pressing Next never starts it and never advances past it. It only plays with the play button in the show view.
Cause:
togglePlayingMedia(used byOutputHelper.playItem) passes the item id togetMedia. Player ids aren't URLs, soisLocalFiletreats them as local files,locateMediaFilefails and the function returns early. The video is never output, soisOutputtedstays false and every Next retries the same item.Separately, YouTube/Vimeo links dragged straight onto a project were stored with
id: "-", which can't be resolved inplayerVideos.Changes
utils/shortcuts.ts: player items skipgetMediaand are output byid(same asVideoShow.playVideo).drawer/player/playerHelper.ts: newgetOrCreatePlayerVideo()finds or adds the Online media entry.helpers/dropActions.ts: links dropped on a project are added to Online media and use that id instead of"-"."-"player items are migrated (registered, and project item id updated) the first time they're played.Testing (macOS,
npm start)🤖 Generated with Claude Code