Repository navigation
fix(football): adaptive layout keeps NFL and NCAA logos apart (3.18.2) - #598
Merged
Merged
Conversation
NFL and NCAA FB share ten abbreviations (CAR CIN DAL DEN HOU LAC MIA NE TB TBD) and one scroll strip carries both leagues. The classic logo cache is scoped by logo directory, but the adaptive path's two caches were not: _load_raw_logo keyed the unresized logo by abbreviation alone, and the LayoutContext fit was cached under "logo:<abbr>". Whichever Miami was drawn first -- Dolphins or Hurricanes -- was drawn on the other's card. Both keys now include _logo_scope(logo_path). Classic layout unchanged. Bumps football-scoreboard to 3.18.2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 19 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
ChuckBuilds
added a commit
that referenced
this pull request
Oct 2, 2026
Conflicts were the 3.18.2 metadata #598 just squash-merged: the branch's manifest and CHANGELOG already carry it under 3.18.3; plugins.json taken from main and regenerated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
NFL and NCAA FB share ten team abbreviations (CAR CIN DAL DEN HOU LAC MIA NE TB TBD), and one scroll strip carries both leagues. The classic logo cache was already scoped by logo directory (
_logo_scope, seetest_logo_cache_league_scope.py). The adaptive layout path (layout_mode: adaptive) keeps two caches of its own, and both were still keyed by abbreviation alone:_raw_logo_cache(unresized logos), keyed"MIA";cache_key="logo:MIA".Whichever Miami was drawn first won: the Hurricanes' card showed the Dolphins' logo, or the other way round. This was found during a core performance investigation (LEDMatrix #716–#719).
What
self._logo_scope(logo_path), the same scoping the classic cache uses.versions[]entry and a CHANGELOG entry.plugins.jsonwas updated viaupdate_registry.py.Tests
test_adaptive_logo_league_scope.py(new, standalone like the other adaptive tests; needsLEDMATRIX_CORE) renders an NFL MIA card and then an NCAA MIA card on one adaptive renderer, in both orders, and checks:On
origin/mainall 3 checks fail: the second card shows 1,936 px of the other league's logo and none of its own. With the fix, 3 pass.Existing tests also pass:
test_logo_cache_league_scope.py(8),test_adaptive_score_clears_logos.py(68 checks), andtest_adaptive_layout_mode/text_colors/upcoming_stacks/scorebug_settings(27, including goldens).Guards:
check_version_bump football-scoreboardPASS,check_manifests_ascii,check_min_core_version,check_module_collisionsandcheck_sports_helpers_parityall PASS.🤖 Generated with Claude Code