Repository navigation
fix(baseball-scoreboard): series summary no longer prints over the score (1.54.1) - #588
Merged
Merged
Conversation
…ore (1.53.2)
show_series_summary drew the series line at the vertical centre of the
full-screen Recent card, on top of the score and the Final/N text. It now
shares the bottom row with the date: date plus series when they fit between
the record corners, the series alone otherwise, then a compact spelling
("Tied 1-1") and finally the small 4x6 font, so the line is never dropped.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 52 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Re-bump baseball-scoreboard to 1.54.1 above main's 1.54.0 (live Vegas cards) and regenerate plugins.json. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Oct 1, 2026
ChuckBuilds
added a commit
that referenced
this pull request
Oct 1, 2026
Baseball._recent_date_text (#588) is not a copy of the promoted method: with a series line the full-screen Recent card draws its own bottom row, so it blanks the date there and otherwise defers to core's via super(). KEEP it with that reason. Found by CI: the local guard loop recorded the exit code of a command substitution rather than of the guard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A user reported a garbled Recent card: with
display_options.show_series_summaryon, "Series tied 1-1" was drawn at the vertical centre of the full-screen card, directly over the score and the "Final/10" text.Fix
The series line now shares the card's bottom row with the date (
baseball.py). It takes the first of these that fits between the record corners:date - seriesTied 1-1,NYY 2-1,NYY W 4-2)The series line is never dropped. Off by default, Recent card only.
Known gap: a 64-wide panel with both team records on leaves no room between the record corners; the line is drawn and can touch them. Fixing it means changing record drawing in the shared
sports.py.Tests
test_series_summary_layout.py(widths 64/96/128/192, with and without records).test_recent_game_date,test_inert_settings_are_hidden,test_traditional_scoreboard,test_scorebug_element_toggles,test_settings_reach_the_manager, schema-settings and version-bump checks pass.check_plugin.pyharness not run locally.Manifest bumped to 1.54.1 (above main's 1.54.0);
plugins.jsonregenerated.🤖 Generated with Claude Code