Repository navigation
feat(weather): the radar animates in the Vegas ticker (core 3.8.0) - #586
Merged
Merged
Conversation
After the forecast cards the Vegas ticker now shows the precipitation radar,
playing the full-screen radar's loop while it scrolls past. Before, the radar
never appeared in Vegas mode at all.
- get_vegas_elements(): the forecast cards (get_vegas_content's, placed as
plain content) and one live 'radar' element, refresh_hz = 1/frame_seconds.
- RadarFetcher.compose_loop(): every frame finished once (frame over the map,
label, progress dots) into an immutable RadarLoop, recomposed only when the
frames or the map change (loop_key). It composes at the size the update
thread fetches for and never touches the viewport, which would drop every
built frame. get_radar_image's composition is shared (_compose), so a loop
frame is byte-identical to what the full-screen radar shows.
- redraw_vegas_element('radar', ...): a lookup of the frame for `at`, on the
full-screen timing (frame_seconds each, the newest held loop_pause_seconds
longer); no drawing, no lock, no fetcher access.
- radar_in_vegas (default true). Floor 3.8.0; on an older core the ticker
keeps showing the cards only.
Also lists core main's new modules in check_min_core_version (as on the other
plugin PRs), so the guard's own test passes.
test_vegas_radar.py (24): loop composition and timing, byte parity with the
full-screen radar, the viewport and playback untouched, the memo, the
elements, the lock-free redraw. It caught the memo recomposing every time
(the key named the lazily built map before it existed).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 600 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
…vegas # Conflicts: # scripts/check_min_core_version.py
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…vegas # Conflicts: # plugins.json
…vegas # Conflicts: # plugins.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The precipitation radar now plays in the Vegas ticker, animated while it scrolls past, after the forecast cards. Before, the radar never appeared in Vegas mode.
radar_in_vegas(default on). Floor 3.8.0: merge after that release; on an older core the ticker keeps showing the cards only.Test plan
test_vegas_radar.py(24); plugin suite 10 pass / 1 skip🤖 Generated with Claude Code