Repository navigation
fix(ufc): follow each bout of a card; odds and headliners (1.18.2, 1.18.3) - #581
Merged
Merged
Conversation
…18.3) ESPN sends a fight card as one event whose competitions are its bouts. The live manager read only competitions[0], so on fight night live_games, the live switch view and the Vegas cards followed the first-listed early prelim instead of the bout in the cage. - 1.18.2: the live fetch splits each card into bouts (keyed by competition id, card as event_id); a bout that has not started has no clock (its "-" read as a running one); each bout is dated with its own segment start. Replayed over all 103 2026 Wayback captures: live_games matched ESPN's in-progress bouts in 103, main in 31. - 1.18.3: odds requests used .../events/<bout>/competitions/<bout>/odds (404 for every fight); each bout now registers its card with the odds manager. Upcoming drops a card's early prelims first when its pool is full, so the co-main and main event stay. Tests replay UFC 331 from recorded ESPN scoreboards. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 39 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ESPN's MMA scoreboard sends a fight card as one event whose competitions are its bouts (early prelims first, main event last). The live manager read only
competitions[0], so on fight nightlive_games, the live switch view and the Vegas cards followed an early prelim that was final hours before the main card.1.18.2 - per-bout live tracking (
mma.pyonly, no sharedsports.pyedits)event_id."-"counted as a running clock, so a scheduled bout sat on the live screen before the card began.live_gamesmatched ESPN's in-progress bouts in 103/103 (main: 31/103).1.18.3 - odds and headliners
.../events/<bout>/competitions/<bout>/odds-> 404. The URL needs the card id; each bout now registers its card with the odds manager. Harness mock keys rekeyed to<card>_<bout>.Verification
run_plugin_tests.py ufc-scoreboard: 26/26 (two new tests over recorded UFC 331 scoreboards; each change fails them when reverted alone)origin/maincore): 16/16 goldens identicalcheck_version_bump.py,update_registry.py --check, manifest schema, allscripts/test_*.py, collision/drift/min-core checks: passNotes
_keep_final_for_vegas/_record_finished_gamelive on the unmergedclaude/vegas-live-cardsbranch; they receive the per-bout details this produces. That branch also bumps ufc's manifest/CHANGELOG, so expect a conflict there.no_data_interval(300 s), delaying the next bout's appearance by up to ~5 min.🤖 Generated with Claude Code