镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix(ufc): follow each bout of a card; odds and headliners (1.18.2, 1.18.3) - #581

Merged
ChuckBuilds merged 1 commit into
mainfrom
claude/goofy-wilbur-1f6b99
Oct 1, 2026
Merged

ChuckBuilds merged 1 commit into
mainfrom
claude/goofy-wilbur-1f6b99

Conversation

@ChuckBuilds

Copy link
Copy Markdown
Owner

What

ESPN's MMA scoreboard sends a fight card as one event whose competitions are its bouts (early prelims first, main event last). The live manager read only competitions[0], so on fight night live_games, the live switch view and the Vegas cards followed an early prelim that was final hours before the main card.

1.18.2 - per-bout live tracking (mma.py only, no shared sports.py edits)

  • The live fetch splits each card into bouts (helper shared with Recent/Upcoming); a bout's id is its competition id, the card is event_id.
  • A bout that has not started has no clock: ESPN's "-" counted as a running clock, so a scheduled bout sat on the live screen before the card began.
  • Each bout is dated with its own segment start, not the card's opening time (Recent now leads with the main card; Upcoming shows the main event at its real time).
  • Replayed all 103 Wayback captures of the 2026 UFC scoreboard: live_games matched ESPN's in-progress bouts in 103/103 (main: 31/103).

1.18.3 - odds and headliners

  • Odds: every request was .../events/<bout>/competitions/<bout>/odds -> 404. The URL needs the card id; each bout now registers its card with the odds manager. Harness mock keys rekeyed to <card>_<bout>.
  • Upcoming: with a full pool, a card's first-listed bouts are dropped first, so the co-main and main event stay (UFC 331 lost both at the default 10).

Verification

  • run_plugin_tests.py ufc-scoreboard: 26/26 (two new tests over recorded UFC 331 scoreboards; each change fails them when reverted alone)
  • Core safety harness (fresh origin/main core): 16/16 goldens identical
  • check_version_bump.py, update_registry.py --check, manifest schema, all scripts/test_*.py, collision/drift/min-core checks: pass

Notes

  • Not checked on hdpi.
  • _keep_final_for_vegas / _record_finished_game live on the unmerged claude/vegas-live-cards branch; they receive the per-bout details this produces. That branch also bumps ufc's manifest/CHANGELOG, so expect a conflict there.
  • Between bouts nothing is live, so polling can fall back to no_data_interval (300 s), delaying the next bout's appearance by up to ~5 min.

🤖 Generated with Claude Code

…18.3)

ESPN sends a fight card as one event whose competitions are its bouts. The
live manager read only competitions[0], so on fight night live_games, the
live switch view and the Vegas cards followed the first-listed early prelim
instead of the bout in the cage.

- 1.18.2: the live fetch splits each card into bouts (keyed by competition
  id, card as event_id); a bout that has not started has no clock (its "-"
  read as a running one); each bout is dated with its own segment start.
  Replayed over all 103 2026 Wayback captures: live_games matched ESPN's
  in-progress bouts in 103, main in 31.
- 1.18.3: odds requests used .../events/<bout>/competitions/<bout>/odds
  (404 for every fight); each bout now registers its card with the odds
  manager. Upcoming drops a card's early prelims first when its pool is
  full, so the co-main and main event stay.

Tests replay UFC 331 from recorded ESPN scoreboards.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: da53c14f-5a03-4fae-86f3-5242bc90e374

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 39 complexity

Metric Results
Complexity 39

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@ChuckBuilds
ChuckBuilds merged commit e0a24e7 into main Oct 1, 2026
4 of 5 checks passed
@ChuckBuilds
ChuckBuilds deleted the claude/goofy-wilbur-1f6b99 branch October 1, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant