[ChuckBuilds]

Stage 2 of the sports-code consolidation, plugin side. Depends on ChuckBuilds/LEDMatrix#665: plugins CI checks out core main, and the new check_min_core_version table entries need that PR's modules. Merge #665 first.

Each scoreboard now uses core's src.common.favorite_team_check and src.common.sports_timezone when the running core has them. On older cores, including 3.5.0, it falls back to its own copy. The bundled copies stay until core 3.6.0 is released. After that, a follow-up raises the minimum core version and deletes them (about 4,100 lines).

Changes

• Favourite check (afl, baseball, basketball, football, hockey, lacrosse, nrl): manager.py imports FavoriteTeamCheck from core. The import has the usual exact-name ModuleNotFoundError guard and falls back to <sport>_favorite_check.py, which is unchanged.
• Timezone (the same seven plus soccer and ufc): a guarded shim is appended to each <sport>_timezone.py. The code above it is byte-unchanged and serves as the fallback.
  • When core has the module, the shim points the public functions at core's, passing the plugin's label and write-back values.
  • When no log is given, it passes the plugin module's logger, so log records keep their logger name.
  • Call sites don't change, and the later cleanup only has to delete the code above the shim.
• Tests: each test_timezone_resolution.py now stubs the system-timezone lookup on whichever module actually resolves it. Otherwise the tests would check the wrong code on the core path.
• New guard, scripts/test_timezone_and_favorite_check_copies.py:
  • The favourite-check copies must be byte-identical to each other and equal to core's module.
  • Each timezone copy's helpers must be AST-equal to core's.
  • Each bundled resolver must match core's answers and log records across 1,152 cases.
  • Every plugin must use the exact-name guard.
  • On the core path, each plugin must behave the same as its fallback.
  • All 16 mutations tried were caught.
• Versions: patch bumps for all 9 (versions[] entries, CHANGELOGs, plugins.json). The minimum core version stays at 3.5.0.
• Table and docs: check_min_core_version.py gets entries for both modules as unreleased (None), and doc 08 is updated.

Verification

Compared against origin/main plugins on core v3.5.0, on both paths: this PR on core #665 (core path) and on core v3.5.0 (fallback).

• Rendering: all 192 harness PNGs are byte-identical on both paths.
• Plugin tests: run_plugin_tests.py gives 322 passed on all three configurations. The same 2 failures happen on main: baseball test_odds_placement and football's interactive test_football_plugin.
• Repo scripts: every scripts/test_*.py and check script matches main. The one exception is test_check_min_core_version, whose new entries need fix(football): a two-point conversion is not a safety (3.28.1) #665's modules. check_version_bump passes naming all 9 ids, and so do update_registry --check, the helpers parity check and the drift check.
• Import check: on the core path, every adopted name resolves to src.common.*. On v3.5.0 each resolves to the bundled module.
• On ledpi (Pi 4, core fix(football): a two-point conversion is not a safety (3.28.1) #665):
  • Baseball, football, hockey and soccer from this branch loaded and ran with no errors.
  • FavoriteTeamCheck resolves to core.
  • An A/B against the 1.51.0 bundled copy gave identical favourite-check log output.

Not changed (owner decisions)

• f1: its timezone copy fits the core module exactly (the guard checks it with label "F1 scoreboard"), but f1 isn't touched here.
• Soccer and ufc: they don't get the favourite-team check, because adding it would be a new feature.

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: d46cec41-122b-43c8-8b73-99e415bae4ab

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 148 complexity

Metric	Results
Complexity	148

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}