Repository navigation
basketball-scoreboard: harness fixture seeds the schedule key the managers read (1.36.1) - #549
Merged
Merged
Conversation
…agers read (1.36.1) The fixture still seeded nba_schedule_2025, a key the managers stopped reading when #524 moved the schedule cache to per-window keys. Every Recent/Upcoming render missed the cache and fetched the frozen January 2026 window from ESPN; those games are all final now, so nba_upcoming drew nothing at all eight sizes. The fill warning only covers panels at least twice the design size, so it flagged five of them. The fixture now seeds nba_schedule_window_14_7. Test fixture only, no runtime change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
ChuckBuilds
added a commit
that referenced
this pull request
Sep 28, 2026
basketball-scoreboard's manifest conflicted with main's 1.36.1 (#549); kept main's history with this change on top as 1.37.0. plugins.json regenerated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The safety harness warned
nba_upcoming (fill warn: extent 0%x0%)at 64x64, 128x64, 256x32, 128x96 and 256x128. In fact Upcoming was blank at all eight sizes: the fill check only runs on panels at least 2x the 128x32 design size, so 64x32, 128x32 and 96x48 were blank with no warning.Cause
This was a harness artifact, not a plugin bug. #524 moved the schedule cache to per-window keys (
nba_schedule_window_14_7for the default 14-day lookback and 7-day lookahead). Hockey's fixture was updated then; basketball's still seedednba_schedule_2025. Every Recent/Upcoming render therefore missed the cache and fetched the frozen window (2026-01-01 to 01-22) live from ESPN; that's where the "ESPN rejected the date range" lines in the harness output came from. All of those games are final now, so Upcoming had nothing to draw, and Recent was drawing real ESPN results instead of the fixture.Fix
test/fixtures/mock.json: renamed the keynba_schedule_2025->nba_schedule_window_14_7test/harness.json: updated_commentto name the right key and say what happens when it goes staleversions[0], CHANGELOG,plugins.jsonviaupdate_registry.py). Test fixture only, no runtime change.Verification
Ran
check_plugin.pyfrom a freshgit archiveof core origin/main (6cfcf2e3):nba_upcoming.pnghas content at all eight sizes (the fixture's DAL @ DEN, 01/16 02:00 UTC); Recent shows the fixture's NY @ BOS finalupdate_registry.py --checkandcheck_version_bump.py --base origin/main basketball-scoreboardpassFollow-up
The baseball (
mlb_schedule_2026) and football (nfl_schedule_2025) fixtures appear to have the same stale key. That's out of scope here and will be handled separately.🤖 Generated with Claude Code