Repository navigation
feat(baseball): football and hockey card fonts by default, and room for the live score (1.48.1) - #532
Merged
Merged
Conversation
…1.48.1) Status text defaulted to Press Start where football and hockey use 4x6 at 6, and the schema named its fonts by alias (press_start, four_by_six) where the other two name the files. The three scoreboards now share identical defaults for score, period, team, status, detail, rank and odds text. Anything a user has set keeps their choice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
…he count The score sat one pixel under the bases/count cluster and read as part of it. Four pixels now, still clamped above the bottom edge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Only the two live cards change (128x64 and 256x128); every other golden is untouched. Pillow 12.3.0, the version the other 70 goldens match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ChuckBuilds
added a commit
that referenced
this pull request
Sep 25, 2026
#532 released a 1.48.1 of its own (card fonts, live score spacing). This branch's unreleased 1.48.1 (update() inside its slot) is folded into its 1.49.0 entry, and main's 1.48.1 sits below it. plugins.json regenerated from the manifests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Baseball's game cards looked different from football's and hockey's in Vegas mode. This PR makes the three scoreboards share one set of default card fonts (users can still set their own), and gives baseball's live card score some room.
What
Before this PR, football and hockey already had identical defaults, and baseball differed in two ways:
config_schema.json,game_renderer.pyandsports.py.press_start,four_by_six) instead of by file name. These are the same fonts, but the three schemas now read the same.The shared defaults are now:
A font or size a user has set in the web UI is kept. Hockey needed no change.
Live card score: on baseball's live scroll/Vegas card the score sat 1 px under the bases and count, so it read as part of them. It now sits 7 px below them, still clamped above the bottom edge. The two live-card golden images (128×64, 256×128) are regenerated for it; every other golden is unchanged.
Baseball 1.48.1, with a
versions[]entry;plugins.jsonupdated. If #523 (baseball 1.49.0) merges first, this needs re-bumping to 1.49.1.Test plan
scripts/test_*.pyguard,check_version_bump.py,check_manifest_version_fields.py,check_sports_drift.pyandupdate_registry.py --checkpass against coremain.mainunderrun_plugin_tests.pyon Windows. Rerun with UTF-8 console output, three of them pass (test_font_aliases.pyincluded).test_odds_placement.pystill fails 2 checks (odds on 64x32 panels), and it fails the same 2 onmain, so it's a separate, existing issue.scripts/test_scroll_card_renders.py: all 72 cards match their goldens (Pillow 12.3.0, the version the other 70 were already matching).test_scorebug_element_toggles.py: 32 checks pass.🤖 Generated with Claude Code