Repository navigation
Fix TalkBack accessibility for Adjust Time feature - #89
Open
Tavallali134 wants to merge 1 commit into
Open
Tavallali134 wants to merge 1 commit into
Tavallali134 wants to merge 1 commit into
Conversation
- Make adjustTimeImg visible/focusable to TalkBack (removed importantForAccessibility="no", added contentDescription). - Add labelFor to H/M/S labels in AdjustTimeDialogFragment.
Tavallali134
force-pushed
the
fix/adjust-time-talkback-accessibility
branch
from
October 27, 2026 22:00
7ca6bd6 to
1769364
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
Why this PR
TalkBack users can't access the "Adjust Time" icon — it was marked
android:importantForAccessibility="no"with nocontentDescription,so the screen reader skips it entirely. Without this fix, blind
players have no in-app way to manually adjust time per player (needed
for FIDE arbiter rules, e.g. +2 min to opponent after an illegal move).
Changes
view_clock_button.xml— removedimportantForAccessibility="no",added
contentDescription="@string/adjust_time"(reuses existingstring), added
focusable="true"+clickable="true".dialog_fragment_adjust_time.xml— addedandroid:labelForto theHour / Minute / Second labels so TalkBack reads them when the matching
EditText is focused.