Repository navigation
[FIX] Clear GcpInstance when restarting a run - #1225
Merged
canihavesomecoffee merged 2 commits intoOct 19, 2026
Merged
canihavesomecoffee merged 2 commits into
canihavesomecoffee merged 2 commits into
Conversation
NaitikVerma6776
requested review from
canihavesomecoffee and
thealphadollar
as code owners
October 4, 2026 11:47
canihavesomecoffee
approved these changes
Oct 19, 2026
Restart only cleared progress and results, so cron still treated the test as running and never started a new VM. Fixes CCExtractor#1224
Sonar python:S6663 failed the PR quality gate because MIMEAccept was indexed with a string. Use accept_json instead.
canihavesomecoffee
force-pushed
the
fix/restart-clears-gcp-instance
branch
from
October 19, 2026 16:37
c09fb37 to
0a9ae41
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1224
What was wrong
Restarting a run (API
POST /api/v1/runs/<id>/restartor UI/test/restart_test/<id>) cleared progress and results so the run looked pending again. It left theGcpInstancerow in place.CI treats any test with a
GcpInstanceas already running:gcp_instanceexcludes those ids from the pending queuestart_testreturns early if a row existsSo restarting a running or stuck run never started a new VM.
What this PR does
Delete the
GcpInstancerow in both restart paths. The old VM, if it is still up, becomes an orphan and can be removed by the existing orphan scanner.Test plan
GcpInstanceGcpInstance