Repository navigation
Conversation
… traceback (Breakthrough#604) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #604
-k/--kernel-sizeofdetect-contentanddetect-adaptivewas passed toContentDetectorunchecked, so 1, even or negative values ended in aValueErrortraceback. It is now validated inCliContextand reported asclick.BadParameter, as--weightsand--downscalealready are:KernelSizeValuealso acceptedkernel-size = 1from a config file, contrary to its docstring, and the detector then raised. It now rejects values below 3 (except -1 = auto), and its message says ">= 3", matching the CLI help, scenedetect.cfg and the docs.Note: on the command line
-k -1is now also rejected with a usage error. The CLI help never documented -1 for-k(only the config file does), and today-k -1crashes with the same traceback.Tests:
test_cli_kernel_size_rejects_invalid(3 CLI cases) andtest_cli_kernel_size_config_file_rejects_one(2 config cases) fail on main (5 failed) and pass with this change (5 passed). In the full suite the only failures are 2 moviepy tests that fail the same way on main because moviepy is not installed locally.AI disclosure: prepared with Claude Code (Claude Opus 5.5) and reviewed by me.
🤖 Generated with Claude Code