Repository navigation
OP-545: Twig templates for blocks and pages - #534
Conversation
jkindly
commented
Sep 20, 2024
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
senghe
left a comment
There was a problem hiding this comment.
It's good. There're two short changes, so I can approve in advance. When you change them, you can go with merge.
| $slug = $request->attributes->get('slug'); | ||
|
|
||
| /** @var PageRepositoryInterface $pageRepository */ | ||
| $pageRepository = $this->get('sylius_cms.repository.page'); |
There was a problem hiding this comment.
I would rather inject services via dependency injection than getting them directly from container
There was a problem hiding this comment.
Me too, but the problem here is that PageController extends ResourceController and constructor will looks like:
public function __construct(MetadataInterface $metadata, RequestConfigurationFactoryInterface $requestConfigurationFactory, ?ViewHandlerInterface $viewHandler, RepositoryInterface $repository, FactoryInterface $factory, NewResourceFactoryInterface $newResourceFactory, ObjectManager $manager, SingleResourceProviderInterface $singleResourceProvider, ResourcesCollectionProviderInterface $resourcesFinder, ResourceFormFactoryInterface $resourceFormFactory, RedirectHandlerInterface $redirectHandler, FlashHelperInterface $flashHelper, AuthorizationCheckerInterface $authorizationChecker, EventDispatcherInterface $eventDispatcher, ?StateMachineInterface $stateMachine, ResourceUpdateHandlerInterface $resourceUpdateHandler, ResourceDeleteHandlerInterface $resourceDeleteHandler) { parent::__construct($metadata, $requestConfigurationFactory, $viewHandler, $repository, $factory, $newResourceFactory, $manager, $singleResourceProvider, $resourcesFinder, $resourceFormFactory, $redirectHandler, $flashHelper, $authorizationChecker, $eventDispatcher, $stateMachine, $resourceUpdateHandler, $resourceDeleteHandler); }
So, I can't use DI here.
| @@ -0,0 +1,10 @@ | |||
| <container xmlns="http://symfony.com/schema/dic/services" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> | |||
| <services> | |||
| <defaults public="true" /> | |||
There was a problem hiding this comment.
Every service in services dir is public, so I went with the project flow. Should I remove it?
There was a problem hiding this comment.
It shouldn't be public, as public services aren't good for containers performance. But please leave it as is.