镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Validate boolean tokens for wrapped _default_on kill-switch readers #24120

Open

Description

@Git-on-my-level

The cross-service reader inventory now recognizes _default_on(<ENV constant>), but the resulting EnvRead has no truthy tokens. check_boolean_tokens therefore skips this reader shape.

In legacy capture-coverage mode, the live-STT helper treats any value outside false/0/off as true. A future typo such as flase could pass the deployment checker and leave a supposedly disabled switch on. The prod replica-recovery declaration in PR #24118 is the valid literal false; this finding does not invalidate that configuration.

Teach the checker the wrapper's boolean grammar and cover both accepted literals and invalid tokens, while preserving rejection of unread ops kill switches. Keep serving behavior unchanged unless separately approved.

Source:

if 'env' in name.lower() or name == '_default_on':

Found by the read-only Luna delta review of #24118 (P2, overall SHIP). Coordination owner: rollout lead; target review/assignment by 2026-11-06. Tracked under the Margin-50 initiative in ANX. Evidence report: data/run-2026-10-13-two-lane-nemotron/swarm/state/refs/routerfix-report-2026-10-30.md in omi-workspace.

Activity

  1. moved this from Someday to In progress in omi TODO / bountieson Oct 30, 2026
  2. Dimank92 commented on Oct 30, 2026

    @Dimank92

    Opened PR #24121 to resolve this issue.

    PR: #24121
    Target payout address: 0xC345C07229307d4f1c7935aD2cAe48e390215808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions