Repository navigation
chore: remove the new-chain flusher and queue - #1063
Draft
rickyrombo wants to merge 2 commits into
Draft
rickyrombo wants to merge 2 commits into
rickyrombo wants to merge 2 commits into
Conversation
The genesis migration no longer copies writes onto the new chain from the API; a standalone mirror in go-openaudio replays the old chain's blocks onto the new chain instead, and the flusher is already off in production. - Delete NewChainFlusher and its tests. - Stop enqueuing confirmed relay transactions into new_chain_queue. - Drop the newChainUrl, newChainQueueEnabled, newChainFlushEnabled, newChainFlushFromBlock, newChainFlushToBlock and newChainInsecureSkipVerify config. The new_chain_queue table and NewChainID config are left in place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nothing reads or writes new_chain_queue since the flusher and relay enqueue were removed, and NewChainID was only stamped by the flusher. - Add migration 0243 to drop the table. - Remove its objects from the schema dump and its generated model. - Remove NewChainID, its per-environment defaults and newChainId. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The genesis migration no longer copies writes onto the new chain from the API. A standalone mirror in go-openaudio (
openaudio mirror, OpenAudio/go-openaudio#605, #608, #610) now replays the old chain's ManageEntity and Plays transactions onto the new chain in block order. The API flusher is already off in production, so the queue, the flusher and their config are dead.Removed
api/new_chain_flusher.goandapi/new_chain_flusher_test.go.api/server.go.new_chain_queue: the fire-and-forgetenqueueForNewChaincall after a confirmed relay inapi/relay.go. The relay still submits to the chain and returns the same response.new_chain_queuetable. Migration0243_drop_new_chain_queue.sqldrops it. Its objects are removed fromsql/01_schema.sql, and its model is removed fromapi/dbv1/models.go. I edited both by hand so a full regeneration's unrelated drift stays out of this PR.NewChainIDand its per-environment defaults. The flusher was the only code that stamped it (fix(api): stamp the new chain ID on flushed transactions #1059).newChainUrl,newChainId,newChainQueueEnabled,newChainFlushEnabled,newChainFlushFromBlock,newChainFlushToBlock,newChainInsecureSkipVerify.Kept
mainand is harmless.etlStartingBlockHeight/etlEndingBlockHeight, feat(api): add the indexer and flusher bounds the chain cutover needs #1028) and play routing (PlayRoutingHosts, feat(api): route stream resolution through named hosts during the chain migration #1029). The cutover still uses both.mustParseInt64Envstays because the ETL bounds use it.Deploy notes
newChainQueueEnabled=truewould log a warning on each relay until it is replaced. Its inserts were fire-and-forget, so relays still succeed.Tests
go build ./...passes.docker compose up -d --waitfrom the edited dump:go test -count=1 -cover ./...passes in 28 packages. Inapi, onlyTestFeedScheduledReleasesfails. It fails the same way onorigin/mainwithout this change.🤖 Generated with Claude Code