Revert "fix(api): stop leaking the probe's skip_play_count into the stream url" (#1027)

api/stream_util.go

@@ -11,10 +11,6 @@ import (
 // tryFindWorkingUrl attempts to validate a media link by checking if it can serve content.
 // It tries the primary URL first, then falls back to mirrors if needed.
 // Returns the first valid URL found or the main URL if nothing works.
-//
-// The returned URL carries no probe artifacts: callers hand it straight to a
-// client, and a stray skip_play_count would stop the serving node from
-// recording the listen.
 func tryFindWorkingUrl(mediaLink *dbv1.MediaLink) *url.URL {
 	mainURL, err := url.Parse(mediaLink.Url)
 	if err != nil {
@@ -38,18 +34,11 @@ func tryFindWorkingUrl(mediaLink *dbv1.MediaLink) *url.URL {
 		Timeout: 5 * time.Second,
 	}
 	for _, u := range urls {
-		// Probe on a COPY. skip_play_count exists so this two-byte probe is not
-		// counted as a listen, but it belongs to the probe alone -- mutating u
-		// would carry the flag into the URL we hand the client, and the node
-		// serving /tracks/cidstream/:cid returns early from logTrackListen when
-		// it sees it. That silently suppressed the play for every caller of
-		// /v1/tracks/:id/stream.
-		probe := *u
-		q := probe.Query()
+		q := u.Query()
 		q.Set("skip_play_count", "true")
-		probe.RawQuery = q.Encode()
+		u.RawQuery = q.Encode()
 
-		req, err := http.NewRequest("GET", probe.String(), nil)
+		req, err := http.NewRequest("GET", u.String(), nil)
 		if err != nil {
 			continue
 		}