This repository was archived by the owner on Aug 13, 2020. It is now read-only.
Repository navigation
This repository was archived by the owner on Aug 13, 2020. It is now read-only.
Update notebook examples #95
Description
After merging #79, the example scripts and the example notebooks do not match anymore. We should keep only the notebook format, therefore:
- Converting the
.pyscripts inexamplesto Jupyter notebooks - Remove the old
examples/examples-notebookdirectory and the.pyscripts inexamples - Make sure these work from mybinder by adding a command to install PyFME, see for instance https://github.com/poliastro/poliastro/blob/1c3c1da/index.ipynb
Activity
aqreed commentedon Nov 14, 2016
Ok I didn't check this before as I thought it did not include deleting the
.py@aeroaks great job anyway with those nb!
aeroaks commentedon Nov 14, 2016
@aqreed Aqr thanks!
AlexS12 commentedon Nov 13, 2017
After the merge of #104 The example notebooks will disappear as we know them now.
In my opinion, adding more examples is a good idea, but instead of having many files with different maneuvers, we could focus on different topics that let the user understand the possibilities of the library:
If you have any idea and some time to work on this, we can keep this issue opened and keep talking 💪
acelere commentedon Nov 17, 2017
I think that the notebook example is much better now. Thank you.
Only one suggestion: if you could add a small cell where you show how to propagate for only one time step, I think this will help in debugging and also, in my case, when implementing this nice model with other flight control modules.
AlexS12 commentedon Nov 18, 2017
Thanks for having a look @acelere! 🎉
I think it is a great idea to add some cells explaining how to propagate for one time step. Then, you can check what's going on, and continue with another time step using propagate again (that will continue integration from the state last propagation generated).
I have just added an example at the end of the notebook! Does it meet your needs? 👍