镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix(ColoredView): ensure removals are displayed for empty lists and dict - #578

Closed
Nagato-Yuzuru wants to merge 1 commit into
qlustered:devfrom
Nagato-Yuzuru:master
Closed

Nagato-Yuzuru wants to merge 1 commit into
qlustered:devfrom
Nagato-Yuzuru:master

Conversation

@Nagato-Yuzuru

Copy link
Copy Markdown

Related issue #575

Correct behavior of ColoredView when comparing empty structures:

  • Show removed items in red for empty lists
  • Show removed items in red for empty dicts
  • Prevent displaying '[]' or '{}' when items are removed
  • Add corresponding test cases

…icts

Correct behavior of ColoredView when comparing empty structures:
- Show removed items in red for empty lists
- Show removed items in red for empty dicts
- Prevent displaying '[]' or '{}' when items are removed

Signed-off-by: Nagato Yuzuru <x4.nagato.yuzuru@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@seperman
seperman changed the base branch from master to dev March 25, 2026 18:47
@seperman

Copy link
Copy Markdown
Member

Hi @Nagato-Yuzuru
Thanks for making the PR. Sorry it took me a long time to review it.
This issue is already resolved in the dev branch. I copied your unit tests though to make sure we didn't miss anything your existing fix was covering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants