Datastore: Allow retry and timeout configuration on a per instance level #3

Activity

1. crwilcox

   transferred this issue fromgoogleapis/google-cloud-pythonon Feb 7, 2020
2. crwilcox

   added

   api: datastoreIssues related to the googleapis/python-datastore API.Issues related to the googleapis/python-datastore API.

   type: questionRequest for information or clarification. Not an issue.Request for information or clarification. Not an issue.

   on Feb 7, 2020
3. tseaver

   self-assigned this

   on Aug 11, 2020
4. tseaver commented on Aug 11, 2020

   

   tseaver

   on Aug 11, 2020

   Last edited by tseaver

   Contributor

   More actions

   Sketch of implementation:

   • Add retry and timeout args to Batch.commit and plumb through to the underlying RPC in _commit.
   • Add retry and timeout args to Client.get, and plumb through to the underlying RPC.
   • Add retry and timeout args to Client.get_multi, and plumb through to the underlying RPC.
   • Add retry and timeout args to Client.put, and plumb through to the underlying RPC (Batch.commit).
   • Add retry and timeout args to Client.put_multi, and plumb through to the underlying RPC (Batch.commit).
   • Add retry and timeout args to Client.delete, and plumb through to the underlying RPC (Batch.commit).
   • Add retry and timeout args to Client.delete_multi, and plumb through to the underlying RPC (Batch.commit).
   • Add retry and timeout args to Client.allocate_ids, and plumb through to the underlying RPC.
   • Add retry and timeout args to Client.reserve_ids, and plumb through to the underlying RPC.
   • Add retry and timeout args to Transaction.begin, and plumb through to the underlying RPC.
   • Add retry and timeout args to Transaction.rollback, and plumb through to the underlying RPC.
   • Add retry and timeout args to Transaction.commit, and plumb through to the base class method.
   • Add retry and timeout args to query.Iterator ctor, and plumb through to the underlying RPC in _next_page.
   • Add retry and timeout args to Query.fetch, and plumb through to the iterator ctor.
5. tseaver

   added 10 commits that reference this issue on Aug 11, 2020

   feat: add 'retry'/'timeout' args to 'Batch.commit'

   ...

   edaaa45

   feat: add 'retry'/'timeout' args to 'Client.get'/'Client.get_multi'

   ...

   8dfbb2d

   feat: add 'retry'/'timeout' args to 'Client.put'/'Client.put_multi'

   ...

   611dadc

   feat: add 'retry'/'timeout' args to 'Client.delete'/'Client.delete_mu…

   ...

   3684244

   feat: add 'retry'/'timeout' args to 'Client.allocate_ids'

   ...

   61e44c6

   feat: add 'retry'/'timeout' args to 'Client.reserve_ids'

   ...

   cb6cc90

   feat: add 'retry'/'timeout' args to 'Transaction.begin'

   ...

   a20a148

   feat: add 'retry'/'timeout' args to 'Transaction.rollback'

   ...

   fae7803

   feat: add 'retry'/'timeout' args to 'Transaction.commit'

   ...

   bf3a417

   feat: add 'retry'/'timeout' to 'Query.fetch' and iterator.

   ...

   ed2061e
6. gcf-merge-on-green

   closed this as completedin #67on Aug 12, 2020
7. gcf-merge-on-green

   added a commit that references this issue on Aug 12, 2020

   feat: add retry and timeout args to API methods (#67)

   ...

   This issue will close once commit f3283e1 is merged into the 'main' branch.

   f3283e1