Repository navigation
Verify SHA-256 of lz4 CLI downloaded in Windows release job - #134
Merged
Merged
Conversation
Fixes #109 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #109.
The Windows job in
build-all-and-publish.ymldownloadslz4_win64_v1_10_0.zipfrom the lz4/lz4 GitHub release and runslz4.exein the job that builds the published DLL. The release asset can be replaced: GitHub reportsimmutable: false, and the asset was updated after the release. This adds a SHA-256 check between download and extraction, and fails the step if the hash doesn't match.8cb562a5…ab74was computed from a fresh download and matches the Scoop manifest for the same URL. GitHub provides no asset digest to cross-check against.workflow_dispatchrun withpublish=falsewould confirm the step works on the Windows runner.🤖 Generated with Claude Code