Repository navigation
Don't restore the Maven cache in the release workflow - #132
Merged
Merged
Conversation
Remove cache: maven from every setup-java step in build-all-and-publish.yml so the native builds and the credentialed publish step always resolve dependencies fresh from Maven Central rather than from a cache entry shared with other workflows on the same ref. test.yml and docs.yml keep their caches. Fixes #110 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110.
This removes
cache: mavenfrom all fivesetup-javasteps inbuild-all-and-publish.yml. That includes the native build jobs and the credentialedassemble/publish job.test.ymlanddocs.ymlkeep their caches.Caches written by PR runs are scoped to the PR ref, so they can't reach a release run. Only code running on
mainor on the release tag could poison the sharedsetup-java-<os>-maven-<hash(pom.xml)>key; one example is the unpinned Python dependencies in the docs job. This is defence in depth. The cost is that each release run downloads its dependencies from Central.How to verify: a
workflow_dispatchrun withpublish=falseshould no longer log "Cache restored from key: setup-java-…".Possible follow-ups, not in this PR:
-ntpto the release./mvnwcalls would cut download log noise.🤖 Generated with Claude Code