Repository navigation
ci: make the NuGet tester AOT publish's wait on the AOT test-app publish optional - #7219
Conversation
…ish optional #7217 made PublishNugetTesterAOTModule depend on PublishTestProjectAOTModule. The Windows NuGet job runs only the Packaging and NuGetPackageTests categories, so PublishTestProjectAOTModule is not registered there and the pipeline failed with ModuleNotRegisteredException. An optional dependency still waits where the module runs and is ignored where it does not.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review: LGTM. Marking the dependency |
[Low impact] This change appears safe to merge. SummaryMakes the NuGet tester’s wait for the AOT test-app publish optional.
Reviews (1) · Last reviewed commit: "ci: make the NuGet tester AOT publish's ..." · Reviewed by Greptile |
Problem
#7217 added
[DependsOn<PublishTestProjectAOTModule>]toPublishNugetTesterAOTModule. Thenuget-package-tests-windowsjob runs the pipeline withcategories: Packaging NuGetPackageTests, soPublishTestProjectAOTModuleis never registered in that job. The pipeline now fails there on every PR (for example this run):The module comment assumed the dependency would be skipped in that job, but a module excluded by a category filter is unregistered, not skipped.
Fix
Mark the dependency
Optional = true. WherePublishTestProjectAOTModuleruns (the main pipeline jobs),PublishNugetTesterAOTModulestill waits for it, so the #7217 contention fix is kept. Where it is not registered, the dependency is ignored.RunAspNetTestsModulealready uses the same pattern inRunEngineTestsModule.RunEngineTestsModulealso gained the dependency in #7217, but it is uncategorised and only runs in jobs that also runPublishTestProjectAOTModule, so it is unaffected.Summary by CodeRabbit