镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

ci: make the NuGet tester AOT publish's wait on the AOT test-app publish optional - #7219

Merged
thomhurst merged 1 commit into
mainfrom
ci/optional-aot-publish-dependency
Oct 20, 2026
Merged

thomhurst merged 1 commit into
mainfrom
ci/optional-aot-publish-dependency

Conversation

@thomhurst

@thomhurst thomhurst commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Problem

#7217 added [DependsOn<PublishTestProjectAOTModule>] to PublishNugetTesterAOTModule. The nuget-package-tests-windows job runs the pipeline with categories: Packaging NuGetPackageTests, so PublishTestProjectAOTModule is never registered in that job. The pipeline now fails there on every PR (for example this run):

ModularPipelines.Exceptions.ModuleNotRegisteredException: Module 'PublishNugetTesterAOTModule' requires 'PublishTestProjectAOTModule', but
'PublishTestProjectAOTModule' has not been registered and could not be auto-registered.

The module comment assumed the dependency would be skipped in that job, but a module excluded by a category filter is unregistered, not skipped.

Fix

Mark the dependency Optional = true. Where PublishTestProjectAOTModule runs (the main pipeline jobs), PublishNugetTesterAOTModule still waits for it, so the #7217 contention fix is kept. Where it is not registered, the dependency is ignored. RunAspNetTestsModule already uses the same pattern in RunEngineTestsModule.

RunEngineTestsModule also gained the dependency in #7217, but it is uncategorised and only runs in jobs that also run PublishTestProjectAOTModule, so it is unaffected.

Summary by CodeRabbit

  • Bug Fixes
    • Improved Windows NuGet pipeline reliability when the optional AOT test publishing step is unavailable.
    • The pipeline now continues successfully in configurations where that step is not registered, while preserving the required wait when it is available.

…ish optional

#7217 made PublishNugetTesterAOTModule depend on PublishTestProjectAOTModule.
The Windows NuGet job runs only the Packaging and NuGetPackageTests
categories, so PublishTestProjectAOTModule is not registered there and the
pipeline failed with ModuleNotRegisteredException. An optional dependency
still waits where the module runs and is ignored where it does not.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T11:50:46.071977Z 0c0ed19 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4f709999-f16f-4db1-8447-fbefff04f88d
📥 Commits

Reviewing files that changed from the base of the PR and between a484753 and 0c0ed19.

📒 Files selected for processing: 1
  • tools/TUnit.Pipeline/Modules/PublishNugetTesterAOTModule.cs
+---------------------------------------+
| `NaN` is not a valid user experience. |
+---------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Review: LGTM. Marking the dependency Optional = true correctly fixes the ModuleNotRegisteredException in the category-filtered Windows NuGet job while keeping the ordering in jobs where PublishTestProjectAOTModule runs. It matches the existing pattern used by RunEngineTestsModule, and the updated comment now describes the behaviour accurately. I couldn't run the pipeline here, so this is based on reading the diff. No further concerns.

@greptile-apps

greptile-apps Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This change appears safe to merge.

Summary

Makes the NuGet tester’s wait for the AOT test-app publish optional.

  • The NuGet tester waits for the AOT app only when it is registered.

Reviews (1) · Last reviewed commit: "ci: make the NuGet tester AOT publish's ..." · Reviewed by Greptile

@thomhurst
thomhurst merged commit fc993b4 into main Oct 20, 2026
9 of 23 checks passed
@thomhurst
thomhurst deleted the ci/optional-aot-publish-dependency branch October 20, 2026 11:51

This branch was successfully deployed

No deployments
Pull Requests — 0c0ed193 Deployed Oct 20, 2026 by thomhurst via modularpipeline (ubuntu-latest) #20345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant