Repository navigation
Scan Next.js dynamic route segments with manual @source rules - #16457
Merged
Merged
Conversation
Contributor
Author
|
Going to close this as it's an upstream issue. We can reopen if we decide to work around it from our side but if we can fix the upstream resource I'd expect this test to also live in the upstream tests. |
philipp-spiess
force-pushed
the
fix/next-dynamic-scanning
branch
from
February 17, 2025 14:53
bc4ef23 to
3e26640
Compare
philipp-spiess
marked this pull request as ready for review
February 17, 2025 14:55
RobinMalfait
approved these changes
Feb 18, 2025
RobinMalfait
left a comment
Contributor
There was a problem hiding this comment.
Pretty cool that this is almost a drop-in replacement 💪
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #16287
Test plan
Added unit and integration tests