Repository navigation
Allow @variant to be used at the top-level - #16129
Merged
Merged
Conversation
thecrypticace
force-pushed
the
fix/top-level-variant-use
branch
from
January 31, 2025 17:15
598e76e to
e0e0c27
Compare
thecrypticace
marked this pull request as ready for review
January 31, 2025 17:22
RobinMalfait
approved these changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so
@variantis replaced at the top level and not just within rules. This also fixes a bug where@variantwasn't handled when inside an@mediaat-rule.