镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

fix #230: regression after fix for #197 - #231

Merged
silkentrance merged 1 commit into
masterfrom
gh-230
Jan 29, 2020
Merged

fix #230: regression after fix for #197#231
silkentrance merged 1 commit into
masterfrom
gh-230

Conversation

@silkentrance

@silkentrance silkentrance commented Jan 29, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • must call either rimraf.sync or rmdirSync during garbage collection and not use a next parameter
  • remove rimraf wrappers, one can directly call the functions and the wrappers do not make any sense

@silkentrance
fix #230: regression after fix for #197 - must call either rimraf.syn…
3aba7d8 
…c or rmdirSync during garbage collection and not use a next parameter
@silkentrance

silkentrance commented Jan 29, 2020

Copy link
Copy Markdown
Collaborator Author

The issue did go unnoticed since all exceptions will be ignored during garbage collection.
And maybe there is a missing test for dirsync and unsafeCleanup. will check.

@silkentrance
silkentrance merged commit 61f9a7d into master Jan 29, 2020
@silkentrance
silkentrance deleted the gh-230 branch January 29, 2020 19:59
This was referenced Mar 14, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@silkentrance