镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

chore: handle unavailable node nightly source - #10021

Merged
reggi merged 1 commit into
latestfrom
fix/node-nightly-source-download
Oct 30, 2026
Merged

reggi merged 1 commit into
latestfrom
fix/node-nightly-source-download

Conversation

@reggi

@reggi reggi commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Summary

Select the newest Node.js version that advertises an available source archive instead of blindly selecting the newest index entry. Download the archive before extraction with explicit HTTP failure handling and retries.

This prevents an incompletely published nightly from being passed to tar as an HTTP error response and allows the workflow to use the newest nightly with source available.

Closes #10016.

Validation

  • Verified nightly selection skips an entry without src and selects the next available nightly.
  • Verified release selection still chooses the newest matching version with src.
  • Verified the generated workflow matches scripts/template-oss/node-integration-yml.hbs.
  • Manual nightly workflow run: https://github.com/npm/cli/actions/runs/35894741221

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: ce1a4b0-26ae-4c30-a086-491e98d1e6da
@reggi
reggi requested a review from a team as a code owner September 23, 2026 17:19
@reggi reggi changed the title fix: handle unavailable node nightly source chore: handle unavailable node nightly source Oct 30, 2026
@reggi
reggi merged commit 7c78fe0 into latest Oct 30, 2026
32 of 36 checks passed
@reggi
reggi deleted the fix/node-nightly-source-download branch October 30, 2026 14:33
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Backport to release/v10 failed.

This usually means the cherry-pick had conflicts. Please create a manual backport:

git fetch origin release/v10
git checkout -b backport/v10/10021 origin/release/v10
git cherry-pick -x 7c78fe0a0ef83883b6c550eb4b33484f3d08895d
# resolve any conflicts, then:
git push origin backport/v10/10021
Error details
Command failed: git cherry-pick -x 7c78fe0a0ef83883b6c550eb4b33484f3d08895d
error: could not apply 7c78fe0a0... chore: handle unavailable node nightly source (#10021)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"


⚠️ Backport to release/v11 failed.

This usually means the cherry-pick had conflicts. Please create a manual backport:

git fetch origin release/v11
git checkout -b backport/v11/10021 origin/release/v11
git cherry-pick -x 7c78fe0a0ef83883b6c550eb4b33484f3d08895d
# resolve any conflicts, then:
git push origin backport/v11/10021
Error details
Command failed: git push origin backport/v11/10021
To https://github.com/npm/cli
 ! [remote rejected]     backport/v11/10021 -> backport/v11/10021 (refusing to allow a GitHub App to create or update workflow `.github/workflows/node-integration.yml` without `workflows` permission)
error: failed to push some refs to 'https://github.com/npm/cli'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: Node.js nightly integration fails while extracting source archive

3 participants