镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

PYTHON-4219 Prep for 4.6.2 Release - #1530

Merged
blink1073 merged 2 commits into
mongodb:v4.6from
blink1073:PYTHON-4219
Feb 20, 2024
Merged

blink1073 merged 2 commits into
mongodb:v4.6from
blink1073:PYTHON-4219

Conversation

@blink1073

Copy link
Copy Markdown
Member

No description provided.

@blink1073
blink1073 requested a review from a team as a code owner February 20, 2024 18:01
@blink1073
blink1073 requested review from caseyclements and removed request for a team February 20, 2024 18:01

@ShaneHarvey ShaneHarvey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to backport the fix for PYTHON-4147.

Comment thread pymongo/_version.py Outdated
from typing import Tuple, Union

version_tuple: Tuple[Union[int, str], ...] = (4, 6, 2, ".dev0")
version_tuple: Tuple[Union[int, str], ...] = (4, 6, 2, "")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically we always remove the "".

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment thread doc/changelog.rst Outdated

PyMongo 4.6.2 fixes the following bug:

- Python 3.12 thread error while using ``MongoClient()`` function.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use the same changelog entry that's in 4.7:

- Fixed a bug appearing in Python 3.12 where "RuntimeError: can't create new thread at interpreter shutdown"
  could be written to stderr when a MongoClient's thread starts as the python interpreter is shutting down.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@blink1073

Copy link
Copy Markdown
Member Author

We still need to backport the fix for PYTHON-4147.

#1532

@caseyclements caseyclements left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants